mitelg / doko-app Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 3.0 1.22 MB

this is a small web app to save points for players of the german card game "Doppelkopf"

License: MIT License

PHP 70.82% CSS 0.22% Shell 4.46% Makefile 0.95% Twig 23.54%

doko-app's People

Contributors

Stargazers

Watchers

Forkers

florianklockenkemper and-wolf

doko-app's Issues

extract logic from controller

the whole app logic is located in the controller. it should be extracted into services and repositories

Tests

the whole app is currently untested. implement a PHPUnit test suite

Use exception

Instead of returning integer codes, the calculateStreaks method should throw exceptions

saving the points of each player seems unnecessary. it should be calculated when the table is shown.
this would also make it possible to delete single games and the points for each player would still be correct

error with no data

completely clean install
create a player
open player stats -> error

Add more tests

add tests for whole logic

two player with the same name

create two player with the same name. Go to enter points page. there is only one of the players selectable. the second one seems to overwrite the first

Recommend Projects