mit-pdos / 6.s060-labs Goto Github PK

Hello,

Unless I'm missing something, I believe this is unintended behavior:

Line 1071 of ag1_runner.py is as follows:

            server._storage.userbase[username] = replace_int(udata, 5, api.OperationCode.PUT_PHOTO, api.OperationCode.REGISTER)

This code does not function as I believe it is intended: instead of replacing the integer value of PUT_PHOTO with the integer value of REGISTER, it replaces the integer value of PUT_PHOTO with the Enum object REGISTER. This results in the decode_log_entry receiving values it items that are neither ints nor bytes types, which would not happen in a real client/server relationship.

To fix this, I think that line 1071 should be replaced with

            server._storage.userbase[username] = replace_int(udata, 5, api.OperationCode.PUT_PHOTO.value, api.OperationCode.REGISTER.value)

This will strictly replace an integer with an integer.