mirumee / django-prices-vatlayer Goto Github PK

django-prices-vatlayer uses cache logic in utils::create_objects_from_json and utils:: get_tax_rates_for_country. It seems that this is not a mandatory step and it doesn't give users any benefits. We should drop them.

Hi,

We love saleor. Especially since the new react-storefront boilerplate. 👍 🚀 And the new SDK with with the outsourcing of the declaration of ApolloClient.
We are starting to have some experience with saleor (build a store with more than 4000 products and integrate with Sage).
And we hope to be more active to the community.

We have identify a little issue with VatLayer free account.
django-prices-vatlayer v1.1.0
saleor v3
VatLayer : Free Account

When we "fetch taxes" from Dashboard Taxes page, we have an unexpected error.

The fetch run 2 calls to the vatlayer API.

• fetch_vat_rates
  All good. The response contain the data.

• fetch_rate_types
  We got a error from API :
  {'success': False, 'error': {'code': 106, 'type': 'rate_limit_reached', 'info': 'You have exceeded the maximum rate limitation allowed on your subscription plan. Please refer to the "Rate Limits" section of the API Documentation for details. '}}

When we comment the first call in your package, the second one run correctly and we could view rate_types in database.
It seems that VatLayer limit the number of calls for a specific time.

Temporise between the 2 calls ? Not really good for the paid account
Add 2 buttons in the Admin Dashboard (fetch rates types, fetch vat rates) ? Not really ergonomic.

Hope this help,
Best,
Sebastien.

Hi!

A little issue when fetching the tax rates with DEBUG = False, if fetches tax rates but the user may not have a paid vat-layer account.

django.core.exceptions.ImproperlyConfigured: Access Restricted - Your current Subscription Plan does not support HTTPS Encryption.

cf.

Proposed solution

We could add a new settings key VATLAYER_USE_HTTPS set to False by default as the paid user may be looking to ensure HTTPS.