mira5619 / f1-3-c2p1-colmar-academy Goto Github PK

Great! I love that you used locally stored media for your project. This is best practice for production code as it makes your page load faster and minimizes reliance on outside sources for content.

Example: https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L16
https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L170

Great! Great nesting, indentation, and comments in your HTML. This makes your markup organized and easy to read. Keep it up!

Example: https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L46-L89

There is one minor error in your HTML line 31, make sure your class value is in quotes, like this: <div class="container">

https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L31

Great! Awesome job with the styling choices, use of flex-box, and use of media queries. Your site looks clean and professional, and is 100% responsive.

Example: https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/resources/css/style.css#L134-L154

I would make sure to remove any styles that are commented out to make your CSS even more organized, clean, and ready for production.
Example: https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/resources/css/style.css#L92-L94

Grade: Exceeds expectations

Summary:
Awesome work on this project! I love your use of semantic elements, locally stored media, your styling choices, and that your site is totally responsive.

A couple things to work on: 1. make sure you have all of your attribute values in quotations in your HTML and 2. clean up your CSS by deleting any styles that are commented out.

Next, I challenge you to build out more pages for this site. What does a sign in page look like? What does a course page look like? This stretch goal will add some complexity to your site and is a challenge I think you are ready for based on your great work here!

Great! Really wonderful job with using semantic HTML elements like <nav>, <section>, <aside>, and <footer>. This helps your markup to be more accessible. Here's a resource on semantic HTML and accessibility: https://webflow.com/blog/html5-semantic-elements-and-webflow-the-essential-guide

https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L13-L26
https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L47-L89
https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L55-L88
https://github.com/mira5619/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L205-L211