mipli / sgf-parser Goto Github PK

Default charset, per the specification, is ISO-8859-1 so we should at least support that encoding properly.

Due to recent support of new nodes, before 2.2 add missing nodes to is_root_token.
And maybe support
is_gameinfo_token
is_setup_property
etc..

The parser now tries to accept file formats with version < 4, even though they're not really supported. The parser should either fail when these versions are encountered, or give a clear warning that parsing will be incomplete due to version mismatch.

Uppercase letters should be interpreted as 27-52 coordinates, see https://www.red-bean.com/sgf/go.html#types

But currently they are interpreted as lowercase letters: https://github.com/mipli/sgf-parser/blob/master/src/token.rs#L679

AB node in an SGF is like this
"AB[ba][ab][ac][bc][bd][be][cf][bg][bh]"
But in the code

"AB" => str_to_coordinates(value)
                .ok()
                .map(|coordinate| SgfToken::Add {
                    color: Color::Black,
                    coordinate,
                })

For me this can't possibly parse multiple values.