minecraftforge / accesstransformers

Antlr4 definition for MCP / Forge Access Transformers

MinecraftForge

Forge is a free, open-source modding API all of your favourite mods use!

Version	Support
1.20.x	Active
1.19.x	Legacy

• Download
• Forum
• Discord
• Documentation

Installing Forge

Go to the Forge website and select the Minecraft version you wish to get Forge for from the list.

You can download the installer for the Recommended Build or the Latest build there. Latest builds may have newer features but may be more unstable as a result. The installer will attempt to install Forge into your vanilla launcher environment, where you can then create a new profile using that version and play the game!

For support and questions, visit the Support Forum or the Forge Discord server.

Creating Mods

See the "Getting Started" section in the Forge Documentation.

Contribute to Forge

If you wish to actually inspect Forge, submit PRs or otherwise work with Forge itself, you're in the right place!

See the guide to setting up a Forge workspace.

Pull requests

See the "Making Changes and Pull Requests" section in the Forge documentation.

Please read the contributing guidelines found here before making a pull request.

Contributor License Agreement

We require all contributors to acknowledge the Forge Contributor License Agreement. Please ensure you have a valid email address associated with your GitHub account to do this. If you have previously signed it, you should be OK.

Donate

Forge is a large project with many collaborators working on it around the clock. Forge is and will always remain free to use and modify. However, it costs money to run such a large project as this, so please consider becoming a patron.

accesstransformers's Issues

Use naming service to transform names

See McModLauncher/modlauncher#21 and MinecraftForge/MinecraftForge#5620

passing a raw URI will fail with illegal characters

The change made here: a129906#diff-e18569b5f9474160905441560c36752eR81

        final URI outJarURI = URI.create("jar:"+toUri.getScheme()+":"+toUri.getPath());

will try to create a new URI with an unencoded path string that may contain illegal characters, which will cause URI#Create to fail.

This can be fixed by returning the result from URI#toASCIIString which encodes it if neccessary:

        final URI outJarURI = URI.create("jar:"+toUri.toASCIIString());

Update ASM to 7

Update ASM to 7

Log4J version bump to >=2.17.1

As stated here: https://logging.apache.org/log4j/2.x/security.html versions below 2.17.1 are affected from the Log4Shell vulnerability.

Therefore the dependency should be bumped to a version greater or equal to 2.17.1.

Proposed changes:

Edit line 111-112 in build.gradle from

implementation('org.apache.logging.log4j:log4j-api:2.11.+')
implementation('org.apache.logging.log4j:log4j-core:2.11.+')

to:

implementation('org.apache.logging.log4j:log4j-api:2.17.1')
implementation('org.apache.logging.log4j:log4j-core:2.17.1')

Suggestion: trim AT lines before parsing

currently, having a leading space in an AT entry silently invalidates the entire file, leading to a cryptic error message like Could not find net.minecraftforge:forge:1.14.4-28.1.109_mapped_snapshot_20191225-1.14.3_at_2c066ae5bccf93f921adfce6242a13228141e4fb.

My suggestion is to simply call String#trim() before parsing AT lines, therefore allowing leading / trailing spaces.

Repo name and examples in FMLAT are misleading

In forge 1.12.2 access transformer files, the srg fieldname is required, but in FMLAT.md, the single-field example uses the deobfuscated name:

public-f net.minecraft.world.WorldType worldTypes

Public AT entries are overriding Public-f entries

Somehow it would appear that public entries are able to override public-f even though public-f entries should have precedence.

This is evident if you install Quark and Toast Control in the same instance.
Quark has the following AT line https://github.com/Vazkii/Quark/blob/master/src/main/resources/META-INF/accesstransformer.cfg#L10

And Toast Control has the same line with -f added https://github.com/Shadows-of-Fire/Toast-Control/blob/1.14/src/main/resources/META-INF/accesstransformer.cfg#L3

The toast control AT is not applied when quark is present in the instance, resulting in the following error https://gist.github.com/Boomflex/ef61e5bd8a85ac3f9ce0452ffd6ebda0#file-gistfile1-txt-L2110

Which occurs because the toastsQueue field is still final when this assignment is invoked https://github.com/Shadows-of-Fire/Toast-Control/blob/1.14/src/main/java/shadows/toaster/BetterGuiToast.java#L18