miloss / jquery-geolocation-edit Goto Github PK

Hi guys,

Great plugin. A couple of small fixes to make the code a bit more robust:

• Currently doesn't support using the script on a https:// encoded page. Throws a security error for trying to load a (hardcoded) insecure script
• Doesn't support jQuery.noConflict() being used (callback code assumes $ will be bound to jQuery)

Have implemented & tested the following fix to line 225 of jquery.geolocation.edit.js:

script.src = ( window.location.protocol == 'https:' ? 'https' : 'http' ) + '://maps.googleapis.com/maps/api/js?sensor=false&callback=jQuery.fn.geolocateGMapsLoaded';

Fix is to detect https, and also to use jQuery for the callback instead of $

Cheers!

I've got an error when initializing the map without using a default latitude / longitude.

When having no default lat/lon the initMap-method is not called. Therefore map and marker are not set and could not be retrieved later.

Thank you for your hard work. I've used your plugin on my development server but when everything was ready for live server I got an error with this (Google Api need key). After that I've created an key in Google and modified your code by adding key. Now it works and I am sorry for making change of your code.