milessabine / exercises-for-programmers Goto Github PK

• You don't need to declare slices globally, you can move that into the main function
• Instead of declaring variable sum, min max, l, diff all at once in the top of the main function, declare each one right before they'll be used. Example:

    sum := 0
    for _, a := range numbers {
        sum += a
    }

• Think about how you would handle the error here
• Think about how you could have used ScanInt here and handled the error as a user having input done, even though you wouldn't be explicitly checking for it

This would be one approach, from https://golang.org/pkg/bufio/#example_Scanner_lines

package main

import (
    "bufio"
    "fmt"
    "os"
)

func main() {
    scanner := bufio.NewScanner(os.Stdin)
    for scanner.Scan() {
        fmt.Println(scanner.Text()) // Println will add back the final '\n'
    }
    if err := scanner.Err(); err != nil {
        fmt.Fprintln(os.Stderr, "reading standard input:", err)
    }
}

It'd be nice to be able to change the prompt for each call, for instance:

getInput("what is the input string?")

or

getInput("what is your name?")