mikkcz / pontoon-addon Goto Github PK

If I select a text on a page, I would like to be able to find it quickly in Pontoon. Bug 1305281 should add a global search, so best to wait for it.

An advanced option is to automatically identify the project the current site belongs to, and search there. The search itself this way is possible, the issues is how to identify the right project, probably hardcode the URLs for now.

This may be a great help to quickly navigate to most used Pontoon pages.

Can include:

• homepage
• team page (need to determine the preferred team, or define it in settings)
• team bugs
• machinery
• projects translations view (need to find out, how to get the list of them)
  ...

Similar to team info component in the toolbar button popup, create a project info into the page action popup.

• name of the project (and team)
• completion status and list of strings by status
• links to open project dashboard, translation view, and bug report

Nonessential ideas:

• last activity (needs API)
• resources links (needs API)
• deadline (available via GQL)
• contact person (available via GQL)

Place the same content below the list of notifications, add two tabs Team and Project, where Team is selected by default and Project is always there, and visually highlighted when the current tab contains a known web project.

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/user_interface/Notifications

I am thinking of to make a prototype adding tabs with additional information, like projects activity, projects deadlines, completion, links to l10n resources etc. The tabs may look like on the Pontoon team page, where you can switch between projects, contributors, bugs and more.

https://github.com/MikkCZ/pontoon-tools/blob/48860e66fb091ad4abf2d19e1392c6e9fb2f6048/src/js/ToolbarButton.js#L24

Has been fixed in bug 1314674.

The unread notifications are actually places also in the <header>. Getting new notifications from any opened Pontoon tab shouldn't be a big problem.

Scenarios:

• newly loaded tab with Pontoon contains new notifications -> update toolbar button and popup
• notifications are marked as read from the popup -> update all opened Pontoon tabs notification bell
• notifications are marked as read in Pontoon -> update toolbar button and popup

#42 is for non-WebExtensions browsers. Let's track this separate, also because the UI would need to be adjusted for mobile.

I would like to make a prototype to explore, how a translation interface built into Firefox could look like. To not reinvent the wheel, it can start its existence as a devtools panel, that can make use of the website elements selection.

And there is a small chance this might be possible for the Firefox UI too!

https://github.com/mdn/webextensions-examples/tree/master/devtools-panels

On slower connection, it may look like nothing happened, until the notifications list gets reloaded.

As a use I want to be able to see the list of notifications without visiting Pontoon, click them to open the project, or mark as read.

Related to #3. See, what https://addons.mozilla.org/firefox/addon/l10n-workflow/ does. Or maybe I can just help to internationalize the L10n Workflow add-on.

Feedback from @FabioBeneditto.

• preferred team (select)
• data update interval (select?)

• display toolbar button badge
• action on toolbar button click (select)

• display page action item
• action on page action click (select)

• reset defaults

Via the Pontoon API we should fetch team data for all teams, instead of parsing the HTML. Having data for all teams will also help to avoid the issue when wrong data are displayed after changing locale team in the add-on options.

Feedback from @jrychly.

@jrychly requested to add an option to hide unread notifications completely and not to follow the behavior of Pontoon from bug 1363164.

Create an introduction page to show and explain all the features after first installation or major update.

This may be a good addition to the notifications list. The first idea is to display a small overview of what's on the team page (percentage, number of strings) and the list of incomplete project similar to what's currently being shown on the team page.

Need to determine the preferred team, or define it in settings.

Add options page with the setting for locale code. Can be just a text input, select with all languages or somehow get this information from Pontoon. Not sure if WebExtensions can access the browser UI locale or preferred languages. If so, these can be used to guess the default.

Blocks #3 and #4.

Chrome, Opera and Edge. Tightly related to #32 (webextension-polyfill) will be needed to pack there.

Step 1

• Chrome (#75) + Chrome Web Store listing

Step 2

• Opera (can be installed from Chrome Web Store using this extensions)

Step 3

• Edge (conversion needed, but the tools does not seem to be available on Linux)
• Safari

blocks #79

This blocks the whole milestone. I need to rewrite most of the code to OOP to be more comfortable making any changes and do not need to spread functionality into multiple functions, like already happened in background.js. https://github.com/MikkCZ/rotate-and-zoom-image is an successfull example of this.

from @mathjazz

The "Load from Pontoon" functionality works fine. The only annoyance
is that for a very brief period of time (maybe 100 ms) the value gets
set to the first item on the list ("ach") and only then to what
Pontoon returns (in my case "sl").

The feature has been added in #38. I should probably change the <select> updating procedure and set the desired team as part of it, not afterwards.

• use browser instead of chrome
• replace all callbacks with promises
• improve performance by Promise.all() and similar techniques instead of hierarchical or events

Currently it behaves the same, like there are no notifications.

https://github.com/mozilla-l10n/mozilla-l10n-query may be a good source

See bug 1317230 fixed in mozilla/pontoon#683.

Link cz_CS on screenshot leads to URL https://pontoon.mozilla.org/cs_CZ/, which throws 404.

Fedora 26, Firefox 55, in Czech

STR:

1. Have Pontoon Tools button in the toolbar.
2. If there are 0 notifications, the badge is gray.
3. With 0 notifications, open new windows (Ctrl+N).
4. The badge in the new windows is read, even if there are no notifications.

I guess there is some default color for the badge, and the color from the first window is not applied. I need to reset the color when a new window is opened, or it may be a bug in Firefox.

Either from button context menu, or from the popup. Do not forget for a proper indication the update is in progress.

It makes sense for too long content, but at this moment it causes horizontal scroll bar to appear too. This should be avoided an only vertical scroll bar shown.

There is a feature that allows you to report l10n bug from the context menu of highlighted text. At this moment, the product is "Mozilla Localization", but the component (locale team) is not set.

First I need to find a source of mapping form the locale code to the right component (note: some teams probably do not have any). Second a question is, whether the component should be according to the team preference, or maybe better detected from the current page locale (that may be a bit harder to find out).

STR:

1. Have an unread notification.
2. Open the popup.
3. Click mark all notifications as read.
4. The button badge gets updated, but the list of notifications does not.

• list read notifications if there are no unread
• update the list style to match Pontoon

In Firefox 58 (23. 1. 2018) the page action icons cannot be completely hidden, but only (de)activated. Also every icon can be moved to the page actions menu, so the self-made option won't be needed anymore.

This will require a mapping from domain to Pontoon project, but will allow to add a page action menu to quickly open Pontoon on the right site, when you are i.e. on addons.mozilla.org and want to update a string there, you just see.

• add page action menu
• add mapping for all project

Context menu for selected text on a page should offer a quick option to report a bug in the Mozilla Localizations product, something like Transvision offers.

Need to find out, if it's even possible to check, if a field has or has not any spellcheck warnings.

Can be specifically used for issues in https://github.com/MikkCZ/pontoon-tools/milestone/2. As part of this staging/developer websites should be recognized too, as well as Appstores pages and pages with screenshots for mobile products.

• get project names
• get project domains (or maybe use contribute.json file from the first known domain?)
• get a complete list of projects including slugs (no hardcoded list anymore)

Per request from @jrychly, it would be nice to open Pontoon on button click instead. The best option is probably the team page (luckily there already is an option to determine the team from #5). This can be configurable in the add-on options.

Match visually and also use radio buttons instead of selects with small number of options.

@jrychly and @MekliCZ reported some issues about flickering screen on Mac, when clicking the toolbar button and opening the popup. Can you please elaborate and ideally attach a recording? What version of Firefox do you use? Can you reproduce it on any other platform too or with any other extension?

At this moment I have no idea for the cause. The data should be always reloaded after the mark-as-read request is completed. This will need some debugging using local instance.

This data can be fetched from https://pontoon.mozilla.org/teams/ at this moment.

As a user I would like to remove notifications as read one by one. At this moment, Pontoon does not support this (bug 1413912), but the add-on can hold the state for each individual notification and mark all notifications as read in Pontoon after all are marked as read in the popup.

Francesco Lodolo has sent a message in Focus for iOS
1 day, 15 hours ago
A new batch of screenshots is available https://drive.google.com/drive/u/0/folders/0BwM0URyvbEeSU251WWtwUjhDalE

was displayed only as

Francesco Lodolo has sent a message in
1 day, 15 hours ago