mikhailpasechnik / ft_ls Goto Github PK

Hard to refactor function (the last one though).

When the array is moved out of the function it starts breaking unexpectedly on large folders..

Norminette output:

$ norminette includes src
Norme: ./src/put.c
Error (line 43): function put_file has 27 lines
Error (line 43, col 0): put_file has 6 variables
Error (line 80): line has 85 characters
Error (line 105): line has 94 characters

"./ft_ls -R libft/tests" in console will produce ODD "libft/tests:" output in the beginning.
It should not put folder name if ONLY ONE DIR is listed (even in "-R" mode).

Output functions should take into account LSCOLORS env variable and colorize names of files according to it's stat.st_mode.

See README.md for more information.

Checker by Moulitest (https://github.com/yyang42/moulitest_42projects) reports many errors.
Note that NOT ALL OF THEM are actually ours, because it checks more flags than our ft_ls features.
However, following flags worth checking:

• R flag
• t flag

See checker output (OK's and odd things are ommitted)

Tests for ft_ls
Source: github.com/yyang42/moulitest
Legend: (.) Ok / (F) Fail / (S) Segfault / (B) Bus error / (T) Timeout / (A) Abort

[ -------STARTING ALL UNIT TESTS------- ]
SOME BASIC FUNCTIONALITY SCREW UPS

00_test_without_opt.spec.c -- [FAIL] ..F [FAIL] simple_test_3 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
01_test_opt_R.spec.c -------- [FAIL] FFFF.FF [FAIL] simple_test_0 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
03_test_multiple_dir.spec.c - [FAIL] FFF.. [FAIL] simple_test_0 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
06_test_opt_rR.spec.c ------- [FAIL] FFFF [FAIL] simple_test_0 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
07_test_opt_t.spec.c -------- [FAIL] ......F [FAIL] simple_test_6 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
07_test_opt_tR_bis.spec.c --- [FAIL] F [FAIL] simple_test_0 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
08_test_opt_l.spec.c -------- [FAIL] ......F [FAIL] simple_test_6 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
09_test_opt_aR.spec.c ------- [FAIL] .F [FAIL] simple_test_1 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
10_test_opt_aRl.spec.c ------ [FAIL] F [FAIL] simple_test_0 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
11_test_single_file.spec.c -- [FAIL] FF [FAIL] simple_test_0 -> strcmp(ls("-l aaa"), ft_ls("-l aaa")) == 0
13_test_hyphen_hard.spec.c -- [FAIL] F.FFFFFF [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
14_test_hyphen_harder.spec.c [FAIL] FFFFFFFFFF [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
20_test_error_handling.spec.c [FAIL] ........FFFFFFF.FFFFFFFFF [FAIL] unitTest_08 -> strcmp(ls_out_str, ft_ls_out_str) == 0
21_test_symlink.spec.c ------ [FAIL] .FFF [FAIL] unitTest_01 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
22_test_no_username.spec.c -- [FAIL] F [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
24_test_multiple_files.spec.c [FAIL] FFF [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
30_test_opt_mix.spec.c ------ [FAIL] F [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0

SOME BONUS FLAGS DOES NOT WORK PROPERLY

bonus_01_test_opt_d.spec.c -- [FAIL] FFF.F...FF [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
bonus_06_test_opt_u.spec.c -- [FAIL] FFFF..FFFFFFFFFFFFFFFF [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
bonus_08_test_opt_1.spec.c -- [FAIL] F. [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
bonus_11_test_opt_g.spec.c -- [FAIL] ..F [FAIL] unitTest_02 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
bonus_21_test_opt_mix_sort.sp [FAIL] FF [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
bonus_22_test_sort_comb.spec. [FAIL] FFFFFFFFFFFF [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0

DOES NOT WORK WITH SPECIAL FILES like in /dev or /var dirs

bonus_34_test_redis.spec.c -- [FAIL] F [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
bonus_40_dir_root.spec.c ---- [FAIL] F [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
sys_00_test_user_bin.spec.c - [FAIL] FF.F [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
sys_01_test_dev.spec.c ------ [FAIL] .FF [FAIL] unitTest_01 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
sys_02_test_etc.spec.c ------ [FAIL] F [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
sys_04_test_var_run.spec.c -- [FAIL] F [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0

(Have not yet done those ->)

bonus_30_test_xattr.spec.c -- [FAIL] F [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
bonus_31_test_usr_xattr.spec. [FAIL] FF [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0
bonus_32_test_ACL.spec.c ---- [FAIL] F [FAIL] unitTest_00 -> strcmp(ls(cmd), ft_ls(cmd)) == 0

[ ----------END OF UNIT TESTS---------- ]

Result: 9/50 test suites passed. 90/241 tests passed (dots).