On YouTube, the additional captions are attached to the wrong DOM node. about dual-captions

[mikesteele]

Hi! :-) I’ve noticed this before, thanks for finding a fix. Feel free to make a pull request if you want, you can add that case to the selector here: https://github.com/mikesteele/dual-captions/blob/4caf76a15a72f2ee248b02d6ed4e190ba974875f/public/content-scripts/config/youtube.js#L22 I’m currently on vacation so I can review your PR, or make my own, after 6/03. Le dim. 27 mai 2018 à 08:33, Rose Perrone <[email protected]> a écrit :

…

Problem: The temporary caption window that says "Spanish (autogenerated). Click <> for settings" has the class "caption-window", so the additional captions are attached to that window, which disappears in a second, so the additional captions also disappear. Suggested fix: In youtube.js, could you attach the captions to the DOM node with id="caption-window-1" or has class "ytp-caption-window-bottom"? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#38>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADuVjYIroErxMcuukwcKMNEf64NLZtYyks5t2eY7gaJpZM4UPFog> .

[roseperrone]

Thanks for your quick reply, Mike! I can wait :)

[mikesteele]

Fixed by PR #39 (thanks again!)

[roseperrone]

I hadn't tested the fix, and now I see this error (screenshot attached) "Two Captions not found on page." Is this error related?

…

On Mon, Jun 4, 2018 at 9:42 AM, Mike Steele ***@***.***> wrote: Closed #38 <#38>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARDoIxxYAVHuX-vn5sz9lX-ykBtsXvJks5t5WN2gaJpZM4UPFog> .

[mikesteele]

I can’t see your screenshot, but that error means content scripts were not injected. I often see it when I install the extension and try to use it on a YouTube tab I opened before I installed. (As content scripts aren’t injected retroactively) That case is expected, which is why I put to try refreshing in the error message. Does it happen on refresh?

[roseperrone]

Thanks for the quick response! The error does happen on refresh. I even tried re-installing the extension and restarting chrome.

…

On Mon, Jun 4, 2018 at 7:15 PM, Mike Steele ***@***.***> wrote: I can’t see your screenshot, but that error means content scripts were not injected. I often see it when I install the extension and try to use it on a YouTube tab I opened before I installed. (As content scripts aren’t injected retroactively) That case is expected, which is why I put to try refreshing in the error message. Does it happen on refresh? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARDoOCeNGalEUeCUY2fRet02r__ZclVks5t5enbgaJpZM4UPFog> .

[mikesteele]

Do you see any errors in the console of the page or in the popup? (You can right click and inspect in the popup to see the popup’s console) Le lun. 4 juin 2018 à 11:03 PM, Rose Perrone <[email protected]> a écrit :

…

Thanks for the quick response! The error does happen on refresh. I even tried re-installing the extension and restarting chrome. On Mon, Jun 4, 2018 at 7:15 PM, Mike Steele ***@***.***> wrote: > I can’t see your screenshot, but that error means content scripts were not > injected. I often see it when I install the extension and try to use it on > a YouTube tab I opened before I installed. (As content scripts aren’t > injected retroactively) That case is expected, which is why I put to try > refreshing in the error message. Does it happen on refresh? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < #38 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AARDoOCeNGalEUeCUY2fRet02r__ZclVks5t5enbgaJpZM4UPFog > > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADuVjQHxvC82dOsBOb-dRFeWEg_WVQmrks5t5fUKgaJpZM4UPFog> .

[mikesteele]

Oh and does it work on Netflix? Le mar. 5 juin 2018 à 6:23 AM, Mike Steele <[email protected]> a écrit :

…

Do you see any errors in the console of the page or in the popup? (You can right click and inspect in the popup to see the popup’s console) Le lun. 4 juin 2018 à 11:03 PM, Rose Perrone ***@***.***> a écrit : > Thanks for the quick response! The error does happen on refresh. I even > tried re-installing the extension and restarting chrome. > > On Mon, Jun 4, 2018 at 7:15 PM, Mike Steele ***@***.***> > wrote: > > > I can’t see your screenshot, but that error means content scripts were > not > > injected. I often see it when I install the extension and try to use it > on > > a YouTube tab I opened before I installed. (As content scripts aren’t > > injected retroactively) That case is expected, which is why I put to try > > refreshing in the error message. Does it happen on refresh? > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > < > #38 (comment) > >, > > or mute the thread > > < > https://github.com/notifications/unsubscribe-auth/AARDoOCeNGalEUeCUY2fRet02r__ZclVks5t5enbgaJpZM4UPFog > > > > . > > > > — > You are receiving this because you modified the open/close state. > > > Reply to this email directly, view it on GitHub > <#38 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ADuVjQHxvC82dOsBOb-dRFeWEg_WVQmrks5t5fUKgaJpZM4UPFog> > . >

[roseperrone]

Thanks! I do see errors in the popup's console. Here's the whole log: i18next::backendConnector: loaded namespace translations for language en Object logger.js:23 i18next: initialized Object middleware.js:27 Middleware: --- middleware.js:28 Middleware: STORE: Object middleware.js:29 Middleware: ACTION: Object middleware.js:30 Middleware: --- logger.js:23 i18next: languageChanged en actions.js:162 actions: Dispatching updateStoreFromDC() middleware.js:27 Middleware: --- middleware.js:28 Middleware: STORE: Object middleware.js:29 Middleware: ACTION: Object middleware.js:30 Middleware: --- actions.js:97 turnDCOn: response: undefined middleware.js:27 Middleware: --- middleware.js:28 Middleware: STORE: Object middleware.js:29 Middleware: ACTION: Object middleware.js:30 Middleware: --- actions.js:128 actions: Can't get active tab ID, am I running locally? I see no logs in the main page's console. I don't have a Netflix subscription, sorry! On Tue, Jun 5, 2018 at 3:31 AM, Mike Steele <[email protected]> wrote:

…

Oh and does it work on Netflix? Le mar. 5 juin 2018 à 6:23 AM, Mike Steele ***@***.***> a écrit : > Do you see any errors in the console of the page or in the popup? (You can > right click and inspect in the popup to see the popup’s console) > > Le lun. 4 juin 2018 à 11:03 PM, Rose Perrone ***@***.***> a > écrit : > >> Thanks for the quick response! The error does happen on refresh. I even >> tried re-installing the extension and restarting chrome. >> >> On Mon, Jun 4, 2018 at 7:15 PM, Mike Steele ***@***.***> >> wrote: >> >> > I can’t see your screenshot, but that error means content scripts were >> not >> > injected. I often see it when I install the extension and try to use it >> on >> > a YouTube tab I opened before I installed. (As content scripts aren’t >> > injected retroactively) That case is expected, which is why I put to try >> > refreshing in the error message. Does it happen on refresh? >> > >> > — >> > You are receiving this because you authored the thread. >> > Reply to this email directly, view it on GitHub >> > < >> #38# issuecomment-394558582 >> >, >> > or mute the thread >> > < >> https://github.com/notifications/unsubscribe-auth/ AARDoOCeNGalEUeCUY2fRet02r__ZclVks5t5enbgaJpZM4UPFog >> > >> > . >> > >> >> — >> You are receiving this because you modified the open/close state. >> >> >> Reply to this email directly, view it on GitHub >> <#38 (comment)- 394566280>, >> or mute the thread >> <https://github.com/notifications/unsubscribe-auth/ADuVjQHxvC82dOsBOb- dRFeWEg_WVQmrks5t5fUKgaJpZM4UPFog> >> . >> > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARDoMzbUNtdiAMC2Fnw1_kAmJ2v3pnDks5t5l32gaJpZM4UPFog> .

[mikesteele]

Thanks for sending these logs. I can see that the popup can't get the ID of the current Chrome tab, which it needs to send a message to turn on dual-captions. It's an odd error, and I'm not sure why it's happening, but I'm fairly sure it's not due to your changes. (It might be the build I uploaded to the Chrome store) I'll update you when I know more. On Tue, Jun 5, 2018 at 12:56 PM, Rose Perrone <[email protected]> wrote:

…

Thanks! I do see errors in the popup's console. Here's the whole log: i18next::backendConnector: loaded namespace translations for language en Object logger.js:23 i18next: initialized Object middleware.js:27 Middleware: --- middleware.js:28 Middleware: STORE: Object middleware.js:29 Middleware: ACTION: Object middleware.js:30 Middleware: --- logger.js:23 i18next: languageChanged en actions.js:162 actions: Dispatching updateStoreFromDC() middleware.js:27 Middleware: --- middleware.js:28 Middleware: STORE: Object middleware.js:29 Middleware: ACTION: Object middleware.js:30 Middleware: --- actions.js:97 turnDCOn: response: undefined middleware.js:27 Middleware: --- middleware.js:28 Middleware: STORE: Object middleware.js:29 Middleware: ACTION: Object middleware.js:30 Middleware: --- actions.js:128 actions: Can't get active tab ID, am I running locally? I see no logs in the main page's console. I don't have a Netflix subscription, sorry! On Tue, Jun 5, 2018 at 3:31 AM, Mike Steele ***@***.***> wrote: > Oh and does it work on Netflix? > > > Le mar. 5 juin 2018 à 6:23 AM, Mike Steele ***@***.***> a écrit : > > > Do you see any errors in the console of the page or in the popup? (You > can > > right click and inspect in the popup to see the popup’s console) > > > > Le lun. 4 juin 2018 à 11:03 PM, Rose Perrone ***@***.*** > > a > > écrit : > > > >> Thanks for the quick response! The error does happen on refresh. I even > >> tried re-installing the extension and restarting chrome. > >> > >> On Mon, Jun 4, 2018 at 7:15 PM, Mike Steele ***@***.*** > > >> wrote: > >> > >> > I can’t see your screenshot, but that error means content scripts were > >> not > >> > injected. I often see it when I install the extension and try to use > it > >> on > >> > a YouTube tab I opened before I installed. (As content scripts aren’t > >> > injected retroactively) That case is expected, which is why I put to > try > >> > refreshing in the error message. Does it happen on refresh? > >> > > >> > — > >> > You are receiving this because you authored the thread. > >> > Reply to this email directly, view it on GitHub > >> > < > >> #38# > issuecomment-394558582 > >> >, > >> > or mute the thread > >> > < > >> https://github.com/notifications/unsubscribe-auth/ > AARDoOCeNGalEUeCUY2fRet02r__ZclVks5t5enbgaJpZM4UPFog > >> > > >> > . > >> > > >> > >> — > >> You are receiving this because you modified the open/close state. > >> > >> > >> Reply to this email directly, view it on GitHub > >> <#38 (comment)- > 394566280>, > >> or mute the thread > >> <https://github.com/notifications/unsubscribe- auth/ADuVjQHxvC82dOsBOb- > dRFeWEg_WVQmrks5t5fUKgaJpZM4UPFog> > >> . > >> > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#38 (comment)- 394661344>, > or mute the thread > <https://github.com/notifications/unsubscribe- auth/AARDoMzbUNtdiAMC2Fnw1_kAmJ2v3pnDks5t5l32gaJpZM4UPFog> > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADuVjYvsCbpoEA1iYe6h6vSgp23TtuXyks5t5rhEgaJpZM4UPFog> .

[mikesteele]

Hey Rose, I shipped a new version of the app to the Chrome Web Store. (v1.3.1) Curious if it fixes this issue for you. Let me know! :-)

[roseperrone]

Sorry, nope. I'm running v1.3.1, and I restarted Chrome and refreshed the page, but I still see these logs in the extension's console: i18next::backendConnector: loaded namespace translations for language en Object logger.js:23 i18next: initialized Object middleware.js:27 Middleware: --- middleware.js:28 Middleware: STORE: Object middleware.js:29 Middleware: ACTION: Object middleware.js:30 Middleware: --- logger.js:23 i18next: languageChanged en actions.js:162 actions: Dispatching updateStoreFromDC() middleware.js:27 Middleware: --- middleware.js:28 Middleware: STORE: Object middleware.js:29 Middleware: ACTION: Object middleware.js:30 Middleware: --- actions.js:97 turnDCOn: response: undefined middleware.js:27 Middleware: --- middleware.js:28 Middleware: STORE: Object middleware.js:29 Middleware: ACTION: Object middleware.js:30 Middleware: --- actions.js:128 actions: Can't get active tab ID, am I running locally?

…

On Tue, Jun 12, 2018 at 5:07 PM, Mike Steele ***@***.***> wrote: Hey Rose, I shipped a new version of the app to the Chrome Web Store. (v1.3.1) Curious if it fixes this issue for you. Let me know! :-) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARDoNarx6AYp9wwGE6Ta3FN3I8iwWafks5t8FfOgaJpZM4UPFog> .

[mikesteele]

Thanks! I still have no idea. 😅

Whenever you have time, see if you get any errors trying to query the active tab ID yourself. You'll have to run these snippets from the popup's console. (I really appreciate you helping me debug this!)

(Adapted from https://github.com/mikesteele/dual-captions/blob/master/src/utils/chrome.js)

window.chrome.tabs.query({
  currentWindow: true,
  active: true
}, tabs => {
  console.log(`Current Window, Active Tab ID: ${tabs[0].id}`);
});

And

window.chrome.tabs.query({
  active: true
}, tabs => {
  console.log(`No current window, Active Tab ID: ${tabs[0].id}`);
});

When I run them, I get:

Current Window, Active Tab ID: 138
No current window, Active Tab ID: 138

[roseperrone]

Sorry for the delay! My output looks just like yours (the IDs are the same in both the first and second log). I'll try to find out why the content script isn't loading when I get some time this week.

…

On Tue, Jun 12, 2018 at 6:01 PM, Mike Steele ***@***.***> wrote: Thanks! I still have no idea. 😅 Whenever you have time, see if you get any errors trying to query the active tab ID yourself. You'll have to run these snippets from the popup's console. (I really appreciate you helping me debug this!) (Adapted from https://github.com/mikesteele/dual-captions/blob/master/src/ utils/chrome.js) window.chrome.tabs.query({ currentWindow: true, active: true }, tabs => { console.log(`Current Window, Active Tab ID: ${tabs[0].id}`); }); And window.chrome.tabs.query({ active: true }, tabs => { console.log(`No current window, Active Tab ID: ${tabs[0].id}`); }); When I run them, I get: Current Window, Active Tab ID: 138 No current window, Active Tab ID: 138 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARDoKxepamaNuqe8QdnzPEcjBYtqGYGks5t8GSCgaJpZM4UPFog> .

[mikesteele]

Awesome! :-) Some relevant files to check: In the manifest, content scripts are listed & injected based on what sites match this regex: https://github.com/mikesteele/dual-captions/blob/master/public/manifest.json#L27 The error you're specifically seeing is that DC didn't send a response. You can see here ( https://github.com/mikesteele/dual-captions/blob/master/public/content-scripts/dual-captions.js#L11) for all the message types DC can respond to, it always sends a response object via `sendResponse()` back to the popup. Your logs show `turnDCOn: response: undefined` which means that DC didn't respond to the turn on message (start-observer), likely because DC wasn't injected. Feel free to send any questions you have while debugging. You can always email me at [email protected] too. On Wed, Jun 13, 2018 at 11:03 PM, Rose Perrone <[email protected]> wrote:

…

Sorry for the delay! My output looks just like yours (the IDs are the same in both the first and second log). I'll try to find out why the content script isn't loading when I get some time this week. On Tue, Jun 12, 2018 at 6:01 PM, Mike Steele ***@***.***> wrote: > Thanks! I still have no idea. 😅 > > Whenever you have time, see if you get any errors trying to query the > active tab ID yourself. You'll have to run these snippets from the popup's > console. (I really appreciate you helping me debug this!) > > (Adapted from https://github.com/mikesteele/ dual-captions/blob/master/src/ > utils/chrome.js) > > window.chrome.tabs.query({ > currentWindow: true, > active: true > }, tabs => { > console.log(`Current Window, Active Tab ID: ${tabs[0].id}`); > }); > > And > > window.chrome.tabs.query({ > active: true > }, tabs => { > console.log(`No current window, Active Tab ID: ${tabs[0].id}`); > }); > > When I run them, I get: > > Current Window, Active Tab ID: 138 > No current window, Active Tab ID: 138 > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#38 (comment)- 396780773>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ AARDoKxepamaNuqe8QdnzPEcjBYtqGYGks5t8GSCgaJpZM4UPFog> > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADuVjdvHE1DjgTSGwg44-_DLusITmMvrks5t8dKVgaJpZM4UPFog> .