mikestead / ecs-task-deploy Goto Github PK

Currently when you launch an update, if the new task fails to come up, or is brought down due to a failing health check, you can be in a situation where ECS service keeps trying to bring back up this failing task even though this deploy tool will have reported the failure.

To avoid this we should add option to rollback the service to the previous task def if the update fails.

ECS has a feature where it is possible to populate env variables from the ssm parameter store.
The task definition the looks kinda like this. https://docs.aws.amazon.com/AmazonECS/latest/developerguide/specifying-sensitive-data.html

{
  "containerDefinitions": [{
    "secrets": [{
      "name": "environment_variable_name",
      "valueFrom": "arn:aws:ssm:region:aws_account_id:parameter/parameter_name"
    }]
  }]
}

In order for secrets to work the property "executionRoleArn" must be set in the task definition but unfortately that property is not preserved by this script.

I opened a pull request to fix this. Would be great if it could be merged in since our deployments rely on this package. Thanks for making it <3

Version 2.32.0 of aws-sdk just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As aws-sdk is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴