mikescops / git-notify-extension Goto Github PK

The todo list only display the latest 20 tasks.

It would be awesome to be notified when:

• a comment is added to a PR, to the PR owner

• a reply is added to a comment, to the comment owner

• a build fails

• all builds passed

Additionaly, could be great to have a mute notifications buttons, for folks who prefer polling their PRs regularly

This error QUOTA_BYTES quota exceeded seems to happen when a user has a lot of PRs/Todos.

Has mentioned here this likely means the max storage in the browser has been hit.

A solution should be to require "unlimitedStorage" capability in manifest.

Draft MRs are currently visible in the 'To Review' list. But those MRs are not supposed to be ready yet.
Can you drop from the list ?

Hi,

The extension popup window won't show up. Here's the console output:

TypeError: "i.issuesAssigned is undefined"
    I moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/popup.3f087480.js:1
    qa moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    Ai moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    vl moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    uc moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    lc moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    Jl moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    Yo moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    unstable_runWithPriority moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:35
    Uo moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    Yo moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    Qo moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    ql moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    mi moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    E moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/popup.3f087480.js:1
2.ca71d911.js:27:82382
    el moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    callback moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    fa moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    al moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    pc moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    unstable_runWithPriority moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:35
    Uo moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    fc moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    Jl moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    Yo moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    unstable_runWithPriority moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:35
    Uo moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    Yo moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    Qo moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    ql moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    mi moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/2.ca71d911.js:27
    E moz-extension://434c2751-6172-4110-a429-28d47d9eb322/assets/popup.3f087480.js:1

From what I understand that would be triggered if I don't have issues assigned to me ? Which is not the case so there must be something else.

I'm using Firefox 77 and Gitlab CE 13.2 (self-hosted)

There's a placeholder for GitLab host address that shows https://gitlab.com
As a user this made me think this greyed out entry was the default one and that if we were using it, we didn't need to fill out any value.
Failure proved me wrong. I think this should be more obvious to the users if they need to fill out a value in case they use gitlab.com, or actually have it as a default value if the input is empty.

Describe the bug
The GItlab Notify "To Review" tab does not match what the site shows I have to review. I think it might have to do with new Gitlab layout/possible API changes.

Expected behavior
I expect to see the correct merge requests show up in my To Review tab in the extension popup.

Screenshots

Desktop (please complete the following information):

• OS: Windows
• Browser Chrome
• Version 115.0.5790.171 (Official Build) (64-bit)

Hello - It would be great of you also have a tab that simply lists/hyperlinks all the projects you're a member or admin of. Will be easier to go and take voluntary updates on each project you're part of.

use case: When you're working on/or part of very many projects - some you're no longer actively tracking. but it would be useful to see a view of all projects and you could decide if you want to check any project.
Maybe an icon showing all developments since you last saw that project could be useful but not necessary.

Hey !

I've noticed negative percentages when hovering over the progress bar in the To-Do List tab. I have 20 tasks to complete but "-12%" is displayed. Also I'm not quite sure what this progress is supposed to show 🤔 .

Thanks!

PR form in Gitlab now has a Reviewers that works like Assignees field just above:

However, when I'm added in this Reviewers field, I won't see the PR in my "To Review" tab. It would be nice if both fields Assignees and Reviewers make the PR appear in the "To Review" tab.

Describe the bug
In the IssueItem, the comments label is missing a space between the icon and the count.

To Reproduce
Steps to reproduce the behavior:

1. Ensure that there are issues assigned to the yourself.
2. Go to Issues
3. Notice the spacing for the comments label is off.

Expected behavior
There should be a space between the comments label icon and the count value.

Screenshots

Suggested Fix
In the IssueItem component, add the   character in between the icon and the user_notes_count.

                        <Label
                            size="small"
                            sx={{ color: 'neutral.emphasis', bg: 'canvas.default' }}
                            className={'mrLabel'}
                        >
                            <CommentDiscussionIcon /> &#160;{issue.user_notes_count}
                        </Label>

Desktop (please complete the following information):

• OS: macOS 13.4.1
• Browser: Chrome v114.0.5735.198
• Version: v2.1.1

The badge currently shows the number of assigned MRs.

It would be great if there was an option to choose which text is displayed on the badge (among the assigned MRs, created MRs, assigned issues, TODO items), or even better a way to select multiple ones and display them as the badge text with a separator like: ⋅ (⋅).

For example, for my workflow I'd love to see assigned MRs and TODO items. If I have 2 MRs assigned and 7 TODOs, I'd expect it would look something like: 2 ⋅ 7.

I don't know if this is a real problem or if it's expected, but the extension tells me that all merge requests (in the "under review" tab) are approved and ready to be merged, even if they are not.

• Using Firefox 102.0.
• Gave all rights to the Gitlab access token.
• Self-hosted gitlab instance 15.0

I think this is a very cool extension but I would need to access the issues for it to be useful. Given that this hasn't been mentioned by anyone else, I'm sure I'm missing something basic with the setup.

Thanks for your help.

Hi,

The extension is not working for me with a self-hosted gitlab-ce. When testing the connection in the preferences I get a "Could not connect" and the popup shows a "Not found" in red. Trying to debug I see a LOT of request on .../approvals which results in a 404 (expected as this is a paying feature). The MR endpoint is returning results correctly so I assume the error comes from the approvals.

Tested on Firefox and Chrome, same issue.

Browser:
Firefox

Issue:
There's a typo for general notifications under the to-do list tab.

Behavior:
"**Your** received a notification"

Expected behavior:
"**You** received a notification"

Recommended fix:
In gitlab-notify-extension/src/popup-components/TodoItem.tsx, the variable actionToText has a default case in the switch statement that is responsible for the displayed text for the items under the to-do tab. Update the return value to the expected behavior.

const actionToText = (author: string, action: string) => {
    switch (action) {
        case 'assigned':
            return author + ' assigned you to';
        case 'mentioned':
            return author + ' mentioned you in';
        case 'build_failed':
            return 'The build failed for';
        case 'approval_required':
            return author + ' set you as an approver on';
        case 'unmergeable':
            return 'The following MR cannot be merged';
        case 'directly_addressed':
            return author + ' tagged you in';
        case 'marked':
            return 'You were marked on';
        default:
            return 'You received a notification';  // fix
    }
};

I'm curious if this is already possible, or what it means for a merge request to show up in "To Review", but I'll explain my use case.

I work across several different repositories and want to know as soon as someone opens a new merge request, or comments on one of the existing ones.

Previously I've used GitLab Notifier for Google Chrome and this allowed me to choose which repositories I wanted events on:

Is this something that I can acheive with this plugin? Or do i need to be mentioend/assigned for a merge request to show up in the list and recieve notifications?

Thanks!

I'm dreaming about that kind if feature as a sysadmin freelance .
Im not often into code reviewing but mainly into config questions.
Thanks !

Hey, thanks a lot for writing this extension, it is exactly what I've been missing all this time. I really would like to use it, but after adding my access code I get these errors. Is there anything I should do to get access. I created an access token with the read_api.

I would really like to use it and would love to support you, if there is any way to donate. Thanks!

https://github.com/Mikescops/gitlab-notify-extension/blob/b1b1cd403aa2e54f58e5ade5ed3628a4a28353ba/package.json#L16

This config is required in order to build the project out of sources.

First, thank you for this extension!

I was wondering if you would consider adding a tab that can show the issues assigned to you.

Something similar to what you see at https://gitlab.com/dashboard/issues?assignee_username=### would be really great!

Happy to contribute some code for this if you consider it a feasible addition to the extension.

I have two open MRs on a project. That project was then Archived while the MRs were still open.
Those MRs continue to appear in the To Review and Under Review lists for the Extension. The list of personal MRs within the Gitlab interface does not show the MRs from the archived project.

Browser: Firefox
Extension Version: 1.5.1

Reproduction steps:

• Start with a project in the regular state
• Open an MR for that project
• Archive the project

Describe the bug
The extension icon is displaying a badge with the number of "To review" items correctly. When I click on the extension menu icon, the dialog appears for half a second and disappears. I have encountered this behaviour in both Edge & Firefox browsers.

Expected behavior
I should be able to view the extension pop-up dialog

Screenshots

Desktop (please complete the following information):

• OS: macOS Ventura 13.2.1
• Browser Edge 110.0.1587.50
• Version110.0.1587.50

I have MR from several code bases in our organization but I need to review one codebase in priority.
It would be nice if I could see the name of the codebase in the MRs list in the popup.

It would be great to have the option to sum all selected counters into one number to show on the badge.

Instead of having something like 0-4-2, it would show as 6 with this option enabled.

Would be great to get notifications for things like the Slack, Discord, Mattermost, etc built in integrations are able to notify.

In particular, I'd be interested in getting being notified about newly opened / closed / draft/notdraft merge requests. (The draft state change ones I don't think the existing integrations can do though.)

Currently we just show MRs that you have been tagged in as an assignee. As with Gitlab 13.7 a new reviewers section (https://about.gitlab.com/releases/2020/12/22/gitlab-13-7-released/#reviewers-for-merge-requests) has been added it would be useful to add these MRs to the same list as those you are assigned in for tracking both. (I don't see any reason to separate them in the UI at this time personally) I went to add this feature but realized that unfortunately the API doesn't support this scope yet and needs to be updated so figured it would be good to track for now. (https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/api/merge_requests.md)