The dynamic-template's discuss from mikemaccana

dynamic-template's Issues

Iterate arrays

Tried rendering an array using this template....

    <ul>
      ${this._items.map((item) => `
        <li>${item}</li>
      `.trim()).join('')}
    </ul>

but this module's function renders it as:

 <ul>
      ${this._items.map((item) =&gt; `
        <li>${item}</li>
      `.trim()).join('')}
 </ul>

is there another technique to get this module to render an array?

Using a Function constructor might be dangerous

an can lead to XSS vulnerabilities. This is an example how this can happen:

https://jsfiddle.net/Lamik/w97qdpvf/

So you should point this out in your module description.

Interpolate nested object properties

It is more a feature request, but ES6 string templates can interpolate the nested properties of an object:

describe('String interpolation', () => {
  it("Allow top level fields ", async () => {
    const res = fillTemplate("A: ${a}, B: ${b}", { a: 100, b: "xxx" })
    expect(res).eq("A: 100, B: xxx")
  })

  it("Allow object fields ES6 dynamic", async () => {
    const res = fillTemplate("A: ${model.a}, B: ${model.b}", { model: { a: 100, b: "xxx" } })
    expect(res).eq("A: 100, B: xxx")
  })

  it("Allow object fields ES6", async () => {
    const obj = { model: { a: 100, b: "xxx" } }
    const res = `A: ${obj.model.a}, B: ${obj.model.b}`
    expect(res).eq("A: 100, B: xxx")
  })
})

This package implements it, but the syntax is questioning: https://www.npmjs.com/package/string-interpolation

Recommend Projects