mikehenrty / thin-pdo-wrapper Goto Github PK

Hey,

just one thing, can you bump the version to release the Composer Autoload Fix to Packagist? The latest "official" Version on Packagist still contains the bug. The dev-master branch is correct for sure.

Thanks!

Singleton patron permit __construct as protected or private?

And maybe will be good block clone method as

public function __clone()
{
trigger_error("Cant clone ". get_class($this) ." class.", E_USER_ERROR );
}

And solution for serialize:

public function __wakeup()
{
trigger_error("Cant unserialize". get_class($this) ." class.");
}

And instance method

if ( !self::$instance instanceof self) {
self::$instance = new self;
}
return self::$instance;

Line 229 is $connection_string .= "port=$port";

Should have a semicolon:

$connection_string .= ";port=$port";

I built the first step in making this PDO wrapper more diverse and I'd like to proceed with phase two.

Phase two would create database-specific adapters to help combat a couple problems encountered from phase one.

Bad news, it would add more files to the wrapper library. Good news, it'll be 100% database agnostic and it will not break any current installs.*

I'm seeking your approval of such an overhaul, I'll still do it but if you prefer not to have it in your main repo, I'll just keep it on my fork and can just be an alt version for those who want it (such as myself ;)).

*as long as they include the adapter to the database their using, so minor code change will be needed depending on how the programmer added the library.

Seems like this version is more up to date.

I see a couple outstanding issues from 2013, and was looking for a lightweight PDO wrapper. I was wondering if this project is maintained.

The most glaring issue I see with this PDO class is that its hard coded to use MySQL.

The connection string portion should get rewritten so that any connection string supported by PDO will work instead of just one.