mikedlowis / libcds Goto Github PK

mem.c is missing tests.

list should include a function for getting index of a node. something like:

int list_index_of(list_t* list, list_node_t* node){
    int i = 0;
    list_node_t* edon = list->head;
    while(edon && edon != node){ edon = edon->next; i++; }
    return (edon ? i : -1);
}

https://github.com/mikedlowis/data-structures/blob/master/source/list/list.c#L168

list_delete returns a list_node_t. but the node returned is mem_released in execution of the function. returned value is useless.

The CDS library should provide a module implementing a traditional logger interface for debugging purposes.

The CDS library should provide a string module providing a safer alternative to standard C strings. Ideally this would support unicode strings as well as ascii.

https://github.com/mikedlowis/data-structures/blob/master/source/list/list.c#L162

the release on this line may cause unexpected behavior. the insert function fails to find the previous node, so it releases the content?

wihtout stddef.h, size_t may be undefined (only applies to dev. branch, since master includes string.h (which includes it for you))

teh fuq is this?

https://github.com/mikedlowis/data-structures/blob/master/source/list/list.c#L70