mijick / popupview Goto Github PK

If in popup view there is scrollable content and it's value bigger than screen's height - we can't scroll it to the bottom
Problem cam be solved with setting view's configuration to
contentFillsWholeHeigh(true) or contentFillsEntireScreen(true)

Hi, i am very like popupView, but when use it in our macOS app, it's muti windows, when i pop it, it's show on every window, Do you have any advice

Issue Description

When implementing a pop-up, the view in which it is hosted is altered. The view should only be as big as its container, but when the pop-up is implemented, it shifts to the top leading position, modifying the view itself.

Steps to Reproduce

1. Create a small view:
   • Create a view that is relatively small.
2. Implement the pop-up:
   • Add the pop-up to the small view.

Observed Behavior

• If the view is small, the pop-up is positioned at the top leading.
• If the view is not small, the pop-up is centered.
• This change does not affect the behavior of the pop-up but modifies the position of the view.

Suggested Solution

Wrap the view in a container to protect its location and size, especially if the view is small. This might be an edge case, as most developers will implement a full view to start their application, but it's worth noting that the original view is modified.

Please help me to fixed it

There is no animation when dismissing a popup, which is a bit of shame as the animation on insert is great

iOS14 CenterPopupView do not display

Hello, I've been using your excellent library, and it works very well. However, I've encountered an issue: when I am in a sheet and try to display a Popup, it opens underneath the currently open sheet, whereas I would like it to appear on top. I hope you can find a solution to this problem.

I've encountered an issue when stacking different components on top of each other, such as SwiftUI views. This results in a weird animation glitch.

Steps to Reproduce:

1. Popup a fullscreen view.
2. From this fullscreen popup, popup a default bottom sheet view.

The animation behaves unexpectedly as shown in the example below.

Additional Feature Request:

It would be beneficial to have a feature that allows developers to set the priorities of popups, similar to the zIndex used internally. This would enable better control over the popup flow without requiring coordination between parts. For example:

1. Example 1: The user is on a settings configuration screen (a fullscreen popup) and receives a message (which should appear as a top popup). The message should overlay the view.
2. Example 2: The user receives a message on top of a fullscreen subscription paywall. The message should NOT be on top of the subscription paywall.

I would appreciate any help in resolving this issue.

App crashes when using center pop-up for macOS. Issue observed in demo app as well.

When I wrap using GeometryReader ,I got results like below image

Code Snippet

'struct BottomPopup_NoCornerRadius: BottomPopup {
    func configurePopup(popup: BottomPopupConfig) -> BottomPopupConfig { popup.cornerRadius(0) }
    func createContent() -> some View {
        GeometryReader{ geo in
            VStack(alignment: .leading, spacing: 0) {
                Text("Test")
                createTitle()
                Spacer.height(16)
                createDescription()
                Spacer.height(36)
                createButtons()
            }
            .padding(.top, 32)
            .padding(.bottom, 12)
            .padding(.horizontal, 28)
        }
        }
      
}
@FulcrumOne 

Demo:

Tap on different items opens screen with cached information
To fix it is needed to use a pause with 0.4 sec before opening the new screen

Attempting to display a center popup from a view presented using .fullScreenCover results in the popup not being shown.

Always after opening the bottom stack when I try to open the center pop it will show on the background. please provide a solution and update the pod as well( I have different schema so I'm currently using your pod library)

I use popupView for a popup that confirms the user is leaving that screen. But the ViewModel cannot be denied when combined
with the popupView, so in the long run it will lead to memory leaks.

The top popup in the Mac OS app leaves unexpected extra space when the window size is slightly large and appears centered when in full-screen mode. Observed this issue in Demo app too.

Popup seems to follow the component with the biggest width in the view?

it works as expected when content overflows to the next line

Code:

`
import MijickPopupView
import SwiftUI

  struct BottomCustomPopup: BottomPopup {
      func createContent() -> some View {
          HStack(spacing: 0) {
              Text("Witaj okrutny świecie")
              Spacer()
              Button(action: dismiss) { Text("Dismiss") }
          }
          .padding(.vertical, 20)
          .padding(.leading, 24)
          .padding(.trailing, 16)
      }
      func configurePopup(popup: BottomPopupConfig) -> BottomPopupConfig {
          popup
              .horizontalPadding(20)
              .bottomPadding(42)
              .cornerRadius(16)
              .tapOutsideToDismiss(true)
              .dragGestureEnabled(true)
              .contentIgnoresSafeArea(true)
      }
  }

`

Hi, thanks for this amazing library. When I present popup view, I get below log in Xcode.
Automatically falling back to Main Thread rendering engine. This fallback comes with some additional performance
overhead, which can be reduced by manually specifying that this animation should always use the Main Thread engine.

I created the following "alert" popup, and when it displays, the safe area at the top is white, despite my background being dark. I would expect any background to be using .clear by default. As a work around, I have implemented my own PopupConfig.

First of all, thank you for the amazing package!

I'm encountering an issue when using popups in combination with views that contain .edgesIgnoringSafeArea(.all). Specifically, I've noticed that when the popup has contentIgnoresSafeArea set to either true or false, the following glitches occur:

1. Animation Glitch:

   • When the popup animation goes from bottom to top, it stops at the safe area boundary before continuing. This results in a noticeable hitch in the animation.

2. Post-Dismissal Lag:

   • After dismissing the popup, there is an animation lag where a thin component of the view remains visible momentarily.

I would greatly appreciate any assistance in resolving this issue.

struct WebViewWrapperView: View {
    
    @Environment(\.presentationMode) private var presentation

    let title : String
    let request: URLRequest
    
    var body: some View {
        VStack {
            navigationBar
            
            titleView
            
            WebView(request: request)
        }
    }
    private var titleView : some View {
        HStack{
            Text(title)
                .modifier(Manrope40Bold())
                .fixedSize(horizontal: false, vertical: true)
                .foregroundColor(Color.black)
                .padding(.bottom, 12)
            Spacer()
        }.padding(.horizontal)
    }
    
    private var navigationBar : some View {
        return HStack {
            Button(action: {
                self.presentation.wrappedValue.dismiss() // dismiss the navigation view
                PopupManager.dismiss()
            }, label: {
                RoundButtonStyleView(buttonType: .backArrow, widthAndHeight: 36, tintColor: .gray, iconColor: .black)

            })
            Spacer()
            
            
        }
        .padding(.horizontal)
        .padding(.top, 60)
    }
}

import SwiftUI
import MijickPopupView

struct PopupFullScreen<Content: View>: BottomPopup {
    var cornerRadius: CGFloat?
    var contentIgnoresSafeArea: Bool?
    var horizontalPadding: CGFloat?
    var backgroundColor: Color?
    var content: () -> Content
    
    init(
        cornerRadius: CGFloat? = nil,
        contentIgnoresSafeArea: Bool? = nil,
        horizontalPadding: CGFloat? = nil,
        backgroundColor: Color? = nil,
        @ViewBuilder content: @escaping () -> Content
    ) {
        self.content = content
        self.cornerRadius = cornerRadius
        self.contentIgnoresSafeArea = contentIgnoresSafeArea
        self.horizontalPadding = horizontalPadding
        self.backgroundColor = backgroundColor
    }
    
    func configurePopup(popup: BottomPopupConfig) -> BottomPopupConfig {
        var modifiedPopup = popup
            .contentFillsEntireScreen(true)
            .dragGestureEnabled(false)
        if let cornerRadius = cornerRadius {
            modifiedPopup = modifiedPopup.cornerRadius(cornerRadius)
        }
        if let contentIgnoresSafeArea = contentIgnoresSafeArea {
            modifiedPopup = modifiedPopup.contentIgnoresSafeArea(contentIgnoresSafeArea)
        }
        if let horizontalPadding = horizontalPadding {
            modifiedPopup = modifiedPopup.horizontalPadding(horizontalPadding)
        }
        if let backgroundColor = backgroundColor {
            modifiedPopup = modifiedPopup.backgroundColour(backgroundColor)
        }
        return modifiedPopup
    }
    
    func createContent() -> some View {
        content()
            .frame(maxHeight: .infinity, alignment: .top)
    }
}

 private func configurePopup(_ config: GlobalConfig) -> GlobalConfig { config
        .top { $0
            .cornerRadius(24)
            .dragGestureEnabled(true)
            .tapOutsideToDismiss(true)
        }
        .centre { $0
            .tapOutsideToDismiss(false)
        }
        .bottom { $0
            .stackLimit(4)
            .tapOutsideToDismiss(true)
        }
    }

Hi, very nice work!

I only have one issue, the BottomPopup is placed under other sheets.

So if I show a sheet, then present a BottomPopup, I have to dismiss the sheet for the BottomPopup to be visible.

Manually computing the screen width limits the usage of the library only for the iPhone and it's not the ideal way for SwiftUI. On iPad, in split screen or with stage manager, UIScreen.main.bounds gives the width of the entire screen, not the width of the app's window.

The fix is actually quite simple, mostly removing some .frame modifiers, like in this example

And now it looks good everywhere.

The background view has the same problem, more apparent on the Mac.

But this too can be fixed quite easily

I can open a pull request with these changes if that's ok for you

Issue Description

When attempting to .showAndStack() two separate center popups with custom views at the same time, the background view always adopts a gray color. This behavior occurs despite different configurations intended for the popups. Additionally, an issue with tap gestures is present when a bottom sheet with a TabView is used; the button tap does not work upon the first appearance.

Steps to Reproduce

1. Implement .showAndStack() with two separate center popups with custom views.
2. Observe that the background view is gray for both popups.
3. Implement a bottom sheet with a TabView.
4. Notice that the button within the TabView does not work on the first appearance.

Expected Behavior

The background view should not default to gray when stacking popups, and all user interactions, such as tap gestures on buttons within a TabView, should be responsive upon the first appearance.

Screenshots

• iPhone 15 Example:
  

• iPhone 15 Pro Example:
  

• Screenshot of Issue:
  

Code Snippet

struct BreakDownBottomSheetView: BottomPopup {

    func configurePopup(popup: BottomPopupConfig) -> BottomPopupConfig {
        popup
            .tapOutsideToDismiss(true)
            .dragGestureEnabled(true)
            .contentIgnoresSafeArea(true)
    }

    func createContent() -> some View {
        VStack(spacing: 15){
            TabView(selection: $index) {
                ForEach(yourDataArray, id: \.self) { item in
                    Button(action: {
                        // Button action here
                        // Doesn't work on first appearance
                    }) {
                        Text("Button for \(item)")
                    }
                    .tabItem {
                        Image(systemName: "some-system-image")
                        Text("Tab \(item)")
                    }
                    .tag(item)
                }
            }
            .tabViewStyle(.page(indexDisplayMode: .never))
            .indexViewStyle(PageIndexViewStyle(backgroundDisplayMode: .never))
        }
    }
}

BreakDownBottomSheetView()
    .showAndStack()

I am setting dismiss after 4 seconds for example. if the user manually dismisses the first notification and a second one is triggered, the first dismiss after 4 that was set on a previous notification seems to dismiss the current notification

It seems like there is a bug with scrolling quickly that causes the full screen bottom sheet to change height: https://share.cleanshot.com/Hlcr715R

If I have a TextEditor on the bottom popup, and the TextEditor is focused, the keyboard doesn't open. I think this is because the bottom PopupView doesn't shift up. Can we make the screen shift up when the keyboard is opened? Thanks.

Congratulations on this awesome library! The only thing missing is to dismiss the popup when touching outside. Would be great if this feature can be added.

Steps to reproduce:
1, Start the app when the phone is in portrait mode.
2, Rotate the phone to landscape mode.
3, Open the bottom PopupView.

The bottom PopupView doesn't span the full screen width. Instead, it displays a shadow strip in the center of the screen with full height.

pod 'Mijick_PopupView'

After pod install
I have to change
import PopView to Mijick_PopupView

but I got this error. please look that issue

Hello,

Thank you for the great package. Would it be possible to add an option to not gray the background (on top or bottom popup) so that they can be use as toast.