migueldvb / cine Goto Github PK

From the first part of the README I get the impression that I'm supposed to use this as a Python library. But then the example suggests this is meant to be a command-line code. That should be clarified.

Also, if it's supposed to be used as a library, there needs to be more documentation (can say more if that's the case).

If I try to do a python setup.py build on a minimal python setup, I get ImportError: No module named setuptools. There are two solutions I know of:

1. use https://bootstrap.pypa.io/ez_setup.py as a bootstrap script which auto-installs setuptools.
2. add "pip install setuptools" to the setup instructions (and maybe catch the import error in your setup.py)

I'd say just do 1, except that its notes say that approach is deprecated. So either of these work.

I have compared the CINE pumping rates for HCN with output from my own code (which has been tested with respect to Biver et al. 2018, Bockelee-Morvan et al. 2004, and Crovisier & Le Bourlot 1983) and they do not seem to be correct - the dominant transitions should be those with delta(J)=2.

While reviewing the JOSS paper for openjournals/joss-reviews#182, I notice there's an author with no orcid (Steven B. Charnley). Is this intended (i.e., he has no orcid), or an oversight?

If I try to import cine from python 2.7, I get a SyntaxError: only named arguments may follow *expression... But the setup.py implies that 2.x is supposed to be supported.

I'm agnostic whether you want to support py2 or not, but it should be stated in the readme (and the setup.py should be consistent what major version(s) of python are supported.