mightygorgon / icy_phoenix Goto Github PK

Last available version of QTE (even for phpBB2) had the color feature with a color palette. It seems like a cool feature to have for non-technical users, thoughts?

Just redirects to bare profile

This should be relatively easy, and I've found a use for this feature many times myself.

The basic premisce is that you can see the first and/or last post of a topic by hovering over it, allowing to see what the topic is about.

I've implemented such a feature on EzArena, so I know exactly how I'm going to do it (I'll try to work on that in january).
This is not going to add SQL queries, only a LEFT JOIN ip_posts fp WHERE fp.post_id = t.first_post_id (fp = first post) (and also probably a column for the poster's information)

I made this a while ago:

https://gist.github.com/vendethiel/3aa38bb6df0a4be16ea4

Do you think we should pursue this idea?

We can probably integrate it into our notifications system

Hey,

I consider this to be a bug: I think users shouldn't be able to thank themselves for a topic they made (that's already there), but I also think they shouldn't be allowed to rate a topic they created. Thoughts?

I guess we need to fix some of these :-)

I tried to look at that last year, and it was a bit overwhelming due to the amount of code.

Getting an error :

[Icy Phoenix Debug] PHP Notice: in file /includes/sessions.php on line 972: Cannot modify header information - headers already sent by (output started at /cache/tpl_default.overall_inc_header_js.php:115)

I don't have any other error tho.

When you're on viewtopic, there exists little icons "top and bottom" next to each posts. Top works, but not bottom.
I guess it's missing an anchor on my theme (prosilver)

(not sure if that's a "new feature" or a "refactor")

The current adm/erc.php is broken anyways, so... Yeah.
This is very low priority though...

https://www.phpbb.com/community/viewtopic.php?f=14&t=2015645

Extracted from: http://www.icyphoenix.com/viewtopic.php?f=12&t=7027

Those would be icons to lock/move/(delete?)/... a topic from viewforum.php, instead of having to open a topic and scroll down to do that. I don't think we need more than that (no quick title form forum).

The idea is from a phpBB2 mod that does exactly this.

This should be simple enough, but requires to have "icons" for lock/move/..., I need to check if we correctly have those for every templates (I think we do).

2.0 was more than 2 years ago :(. Even if there isn't too many improvements to list, we should probably release 2.1 soon-ish. (plus it looks like we're keeping up with phpb3.1's release date hehe... Just kidding)

@MightyGorgon I think you were working on something pretty big? Do you know when you'll have time to wrap it up?

Some forums like IPB, VB (and now a phpBB3.1 extension) allow you to show the first post of the topic on every page.
This is very useful for KB-style forums, for announcements, and for some others. I'd like to have this, at this point, as a per-forum option.

Thoughts?

405a99f#commitcomment-8348480

Mighty Gorgon said:
Yes, maybe those are obsolete... maybe we should even merge all social accounts within one single fields in DB, just to save space for unused columns and spare extra work in the future... in this way new social fields could be customized without even adding any column to DB.

What do you think?

Would you like to work on this ?
Informpro said:
This is definitely something to do! Though one could argue it conflicts with the ability to add field to the profile, maybe?

Also, something not to forget: if we do as you say, we need to be very careful. Maybe store them as json or something, but not as pipe-separated values (if we DID store them as pipe-separated values, we'd need to walk the entire DB everytime the admin adds/removes a field, to remove the value. Pretty bad!). Storing it in one column also means no search, but I think it's okay.

Take #2...

jellydoughnut/phpbb3@develop-olympus...feature/soft-delete

Disclaimer: DISCUSSION ONLY: I'm just talking about what we can improve. I'm not sure I can help for now (and anyways I have stuff I want to do before), because I'm not sure I know IP's core well enough for now. But I'd like to discuss a bit about a "better" IP, even if it only comes true in 2 years. I know you don't have much time, so don't think I'm asking you to do these. Thank you for your work, MG!

When you're on any page (almost, sometimes the SQL for counting isn't triggered for performance reasons), you see that:

Posts: New (0) • U (0) • M (0) • P (0)

I think that's unnecessary, and a lot of users (myself included) only use "unread" (and sometimes "new" to go back to a post I just read). Maybe we could only keep "Unreads:" (and maybe "new") visible, and add an arrow after "Unreads: " that'd show the rest.
The "drop-down" would look the same as the "search dropdown" (not enabled on ip.com) or the "▼" next to the username on phpBB3.1.

Hey,

I want to try and convert the medal mod (which I updated to IP2.0) to use the plugins system.
I think the first thing to do is: replace everything if (plugins['cash' or 'kb' or...]['enabled']) { ... } with non-plugin-specific ones (like $plugins->trigger('event_name')).
I chose the medal mod in particular because it seems very straightforward (it's just a bunch of includes).

Of course we need to decide how we're going to do the template changes (or, for now, leave the template changes to the user maybe... I don't really like this solution either).

The "function trigger" in class_plugins will, however, have to global quite a lot of variables to be usable in other files, but I don't think there's a way around that.
Or, we could just inline the loop on every plugin everytime we need to trigger an event, but I think it's not very nice.

Anyways, we need to have a chat about that, so if I do work on that it'll probably be in january

So, I don't think the Statistics thing is used as good as it could.
I think it'd be amazing if we could get those as CMS modules :-).
Not sure if we can just "embed" them

Or is there a reason there isn't currently?

When I try to delete a category that has forums, and I select "delete all posts", I says "nowhere to move to!"

To simplify this kind of code:

        $db->sql_return_on_error($return);
        $db->sql_query($sql);
        $db->sql_return_on_error(false);

this is just boilerplate :-)

Disclaimer: DISCUSSION ONLY: I'm just talking about what we can improve. I'm not sure I can help for now (and anyways I have stuff I want to do before), because I'm not sure I know IP's core well enough for now. But I'd like to discuss a bit about a "better" IP, even if it only comes true in 2 years. I know you don't have much time, so don't think I'm asking you to do these. Thank you for your work, MG!

I'm not sure why we need the SID anymore? What is it used for? I think $_SESSION is better...

Also, that'd fix this vulnerability
http://www.phpbb2refugees.com/viewtopic.php?t=203 (maybe it's already fixed)

for password encoding etc

Hi,

the sortable functionality on blocks (cms) isn't working

I still need to dig deeper, but I've had that on a production forum

On large board, the update of topic_views on every single page, a technique I used on large boards is to rand(0, 3) to decide if I should update views (if the rand is equal to 3, I add 3 views in one query, so I save 2/3 of the topic_views queries)

This should most definitely be an option, though :-)

Basically if the group's rank is blank, groupcp.php view will have a <img src="./" />, we should display rank name instead.

That seems to be the only improvement in phpBB3.1 for the end user.

AJAX for mod actions, maybe posting?

I "can" work on that, but after I've done everything else.

Hi,

the sortable blocks aren't saved in cms management.

should be easy enough =)

Php notice on includes/class_stats_module l391 end() expects parameter 1 to be an array, null given

It just shows "Min_user_age_explain"

If you set a group with "auto join on postcount: 3"
and you change the poster of some posts to "account A"
then "account A" will not get added to the group

Disclaimer: DISCUSSION ONLY: I'm just talking about what we can improve. I'm not sure I can help for now (and anyways I have stuff I want to do before), because I'm not sure I know IP's core well enough for now. But I'd like to discuss a bit about a "better" IP, even if it only comes true in 2 years. I know you don't have much time, so don't think I'm asking you to do these. Thank you for your work, MG!

phpBB3.1 added a new "notifications" system, that basically shows "last events" like on most social networks: when somebody answered on a topic you posted in, when somebody quoted you, (why not) when someone thanked you, etc... (you could even see something like, when somebody left a profile message, like IPB has... But I really disgress...)

We have something like this already (unread/new)... I think we can just add new stuff (a special type of notifications for a reply or a quote, say, or a thanks) on top of the current "unread" page, maybe?
Or is the system just too deep in to be changed by now?

I wasn't part of the staff when http://www.icyphoenix.com/viewtopic.php?f=40&t=6653 was created, so I just now realized this topic existed:
http://www.icyphoenix.com/viewtopic.php?f=12&t=6723
and that you said this:
http://www.icyphoenix.com/viewtopic.php?f=28&t=6653&start=30

(yes, I browse very old topics once in a while)

As I've did the original code, I could work on it again, it's very very simple (maybe 10 lines of code?) but it needs to "blend in" in every template and that's something I probably can't do.

When you go to the ACP, you're asked to log in once more.

On this page, you shouldn't facebook connect and "remember me" available

In viewforum.php, there are 2 distinct queries made, the first one for GLOBAL anns, the second one for forum-local annoncements.
I don't see any reason for that, and I think a refactoring to have only one query would be good.

The error message appears on install.

Solution : change these methods to be static.

After doing some very simple benchmarks, it seems the jumpbox is responsible for around 10ms (with ~40 forums) to generate it. It can't be cached, as it's per-user.
How about loading it through AJAX?

I don't volunteer to do it (not now, at least...) but if you think it's worth it, I can look at it in the future.

This peice of code:

// Start Yellow Card Changes for phpBB Styles
 $allowed_styles = array(
  'ca_aphrodite',
  'squared',
 );
 if(in_array($theme['template_name'], $allowed_styles))
 {
  $phpbb_styles = true;
 }
 else
 {
  $phpbb_styles = false;
 }

needs to go.

[Icy Phoenix Debug] PHP Notice: in file /includes/usercp_signature.php on line 22: Creating default object from empty value

Got that on icyphoenix.es

That one was assigned to KasLimon in the Tasks List (I'm just posting the leftover tasks here).

When you enable the "search by first topic title letter" (global switch + per forum), it'll only look for capital letters as the first letter.

Looks like a bug to me, can you confirm MG? You might want it that way

I think I looked at that some time ago, but I abandoned. Reading the code again now, I can't remember why I did that... I think @GabrielAnca did a good job.

Currently, in the ACP>Main settings, there's this:

"TAGS :: Enable jQuery Tags"
"TAGS :: Display Topics Tags"

(same for likes and stuff)

I think they would be much better as "section" (like the "Posting Settings" and "Spam Measures" ones).
It makes it easier to see the different parts of it (I'm always looking for an option, if they had a header I'd find it right away I think)

as we discussed some months ago ...