Common DocFx [!NOTE] notation being flagged with verify links about vscode-markdown-languageservice

[lucaspar]

Agreed - I suggest updating the issue title to cover all Markdown alerts, something like

Markdown alerts cause false positives from link detection feature (link.no-such-reference).

• Other false-positive link detection issues:
  • #155
  • microsoft/vscode#150672
• Markdown alerts:
  • Discussion
  • Description

That should cover at least [!NOTE], [!TIP], [!IMPORTANT], [!CAUTION], and [!WARNING] but perhaps this could be safely generalized for any "links" that start with a bang !.

[lucaspar]

It seems this is the block that needs to change - if any devs want to take on this task:

vscode-markdown-languageservice/src/languageFeatures/documentLinks.ts

Lines 291 to 314 in eb65157

	/**
	* Matches `[text][ref]` or `[shorthand]` or `[shorthand][]`
	*/
	const referenceLinkPattern = new RegExp(
	r`(^|[^\]\\])` + // Must not start with another bracket (workaround for lack of support for negative look behinds)
	r`(?:` +
	/**/r`(?:` +
	/****/r`(` + // Start link prefix
	/******/r`!?` + // Optional image ref
	/******/r`\[((?:` +// Link text
	/********/r`\\\]|` + // escaped bracket, or...
	/********/r`[^\[\]]|` + //non bracket char, or...
	/********/r`\[[^\[\]]*\]` + // matched bracket pair
	/******/`+)*)\]` + // end link text
	/******/r`\[\s*?` + // Start of link def
	/****/r`)` + // end link prefix
	/****/r`(` +
	/******/r`[^\]]*?)\]` + //link def
	/******/r`|` +
	/******/r`\[\s*?([^\\\]]*?)\s*\])(?![\(])` +
	r`)`,
	'gm');

[mjbvz]

I'm good with adding a special case for [! refs. Spec wise you can write:

[!NOTE]

[!NOTE]: http://example.com

but it's likely not common