Path suggestions insert invalid path if file name contains `%` about vscode-markdown-languageservice

[mjbvz]

I just tested <img> paths on a few servers and with file: uris. In all cases, %2d seems to be decoded into - when resolving the path

If the file name has the literal text %2d in it, I think the proper encoding would be to also encode the percent sign: %252d. But now we're double encoding and I'm guessing ADO won't understand that anyways

ADO seems to be doing something nonstandard, although I'd be happy to be proven wrong if you can point me to a spec saying otherwise. Maybe it worked differently in older VS Code versions, but that was likely a bug with VS Code also not following standard behavior

---

For the preview, an extension could use a markdown extension to change how paths are resolved

For the editor, an extension could also provide it's own document links instead of relying on VS Code's

[teppolainio]

Ah, my bad @mjbvz for bad bug report. I iterated my finding a bit based on your input and now it seems there might be a bug on how VSCode takes file name literals to Markdown links instaed of encoded file names.

Bit of a story and investigation following up

ADO wiki requires file name literal to have %2D if I need to have - shown on ADO wiki UI. For example if I need to have wiki page "One-dimensional" on ADO wiki I need to have its file name literally One%2Ddimensional.md on file system according to https://learn.microsoft.com/en-us/azure/devops/project/wiki/wiki-file-structure?view=azure-devops#file-naming-conventions (ADO wiki takes wiki page name from file name).

I tried again with following steps:

1. Create file One%2Ddimensional.md to file system.
2. Open another Markdown file (markdown2.md) in order to create link to file One%2Ddimensional.md.
3. Start writing markdown as: [Link](./One to markdown2.md and accept automatically suggested file One%2Ddimensional.md. This creates Markdown snippet [Link](./One%2Ddimensional.md).
4. Open preview of markdown2.md and click "Link".
5. Observe how editor does not find file One-dimensional.md

Now it seems that issue might actually be VSCode givin non-encoded file name One%2Ddimensional.md from file system to Markdown link instead of encoded file name One%252Ddimensional.md. Quick test with ADO wiki hints that ADO wiki supports encoded file name.

Please see picture below. I attached this just to be sure we understand scenario same way.

[mjbvz]

Ok, thanks for the details. It sounds like the bug is with VS Code's path suggestions. I'll move this to the correct repo and update the title