Coder Social home page Coder Social logo

Comments (10)

Neumann-A avatar Neumann-A commented on August 25, 2024 1
C:/root_v6.26.10/cmake/ROOTConfig.cmake(120):  if(MSVC )
C:/root_v6.26.10/cmake/ROOTConfig.cmake(121):  set(CMAKE_FIND_LIBRARY_PREFIXES lib )
C:/root_v6.26.10/cmake/ROOTConfig.cmake(122):  set(CMAKE_FIND_LIBRARY_SUFFIXES .lib .dll )

from vcpkg.

petrmanek avatar petrmanek commented on August 25, 2024

A quick update: I confirmed that the following variables are configured to empty strings (as they should be on Windows) at the time when find_package(zlib) is called:

  • CMAKE_IMPORT_LIBRARY_PREFIX
  • CMAKE_SHARED_LIBRARY_PREFIX
  • CMAKE_STATIC_LIBRARY_PREFIX

from vcpkg.

Neumann-A avatar Neumann-A commented on August 25, 2024

IT IS: find_package(ZLIB REQUIRED)

This seems to me like the 'lib' prefix is incorrectly applied inside vcpkg cmake module for zlib.

give a --trace-expand log if that doesn't fix it

from vcpkg.

petrmanek avatar petrmanek commented on August 25, 2024

IT IS: find_package(ZLIB REQUIRED)

My bad, I typed too fast. Yes, I am aware of that. Just for context: my project does not depend on zlib directly, instead it includes another package (QuaZip) that depends on zlib. I can confirm that QuaZip uses the correct capitalization.

I will provide a --trace-expand log in a moment.

from vcpkg.

petrmanek avatar petrmanek commented on August 25, 2024

@Neumann-A Here you go: 41835.log (11 MB)

from vcpkg.

petrmanek avatar petrmanek commented on August 25, 2024

Lol, you beat me to it by a second!

from vcpkg.

petrmanek avatar petrmanek commented on August 25, 2024

It seems that simply having a dependency on the ROOT framework seems to mess up CMAKE_FIND_LIBRARY_PREFIXES, and zlib is an innocent casualty.

from vcpkg.

petrmanek avatar petrmanek commented on August 25, 2024

Since I am using a little bit outdated version of ROOT (6.26), I will confirm that this behavior is present in the latest version (6.32) as well, and file a bug report upstream if need be. I suppose that this is not a vcpkg problem after all.

Thanks for a quick exchange, I am closing this as resolved.

from vcpkg.

Neumann-A avatar Neumann-A commented on August 25, 2024

Feel free to use/update https://github.com/Neumann-A/my-vcpkg-ports/tree/master/root
However debug builds of root are buggy / not working on windows.

from vcpkg.

petrmanek avatar petrmanek commented on August 25, 2024

@Neumann-A Thanks, I will check it out!

In the meantime, I have confirmed that this behavior is indeed present in ROOT 6.32. I will file a bug upstream in a moment.

from vcpkg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.