[skia] Unresolved external symbol SkSVGDOM::Builder::make about vcpkg

[dg0yt]

Hm, skia svg lives in "modules", but I see little indication of our port building/installing this module in vcpkg CI for x64-windows.

In fact, it seems to be off by default in shared library linkage,
https://github.com/google/skia/blob/ad3c9f203f4e65d0070b1257f40479563e416c46/gn/skia.gni#L27
I don't know if it would work as a DLL.

[cosmin42]

The same issue is occurring when using the static triplet x64-windows-static.

I noticed that the source file for the said symbol can be found under a cleaning folder along with the whole component, it just seems to be discarded and not used in the final lib.

vcpkg/buildtrees/skia/src/1c27019d33-728a6df320.clean/modules/svg ((2024.04.26))
$ ls
BUILD.gn  include/  src/  svg.gni  tests/  utils/

[dg0yt]

That's not a "cleaning" folder, but the clean source dir, recreated before each build. (A different dir is used for --editable mode which reuse am existing (possibly edited) source dir.

And "modules" is the part which tells us that it is not expected to be in the main lib/target. You may need to link another lib/target. The static build has a svg.lib, and there should be a corresponding cmake config/target.

[cosmin42]

Actually sk_sp<SkSVGDOM> make(SkStream&) const; seems to be working along with the -static triplet, I should have clean up the build. Thanks!