microsoft / sqlops-dataprotocolclient Goto Github PK

Here we defined the parameter for onConnectionChanged to have an "ownerUri" property, but the corresponding type in ADS of ChangedConnectionInfo has connectionUri.

Since extensions are typically only going to be using the azdata typings this shouldn't be the case, and could easily lead to providers sending the wrong values.

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

Event handlers such as ConnectionProvider#registerOnConnectionComplete only accept a single event handler. Any new event handler overwrites the existing one. Which means extensions aren't able to use these register... functions on an existing provider without breaking the app (since generally these are supposed to be used by the creator of the provider to handle events coming from core and process them)

Running yarn from master gives the following error:

src/main.ts(381,23): error TS2694: Namespace ''sqlops'' has no exported member 'SyntaxParseParams'.
src/protocol.ts(388,45): error TS2694: Namespace ''sqlops'' has no exported member 'SyntaxParseParams'.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] compile: tsc -p ./src
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above

Would like to propose adding some documentation in Readme/Wiki about:

• What's the goal/requirements of this repository?
• When should one update the code in this repository?
• Who is the customer/end user of releases?
• Release timeline and how are releases validated.

This dependency is broken and doesn't compile under typescript.