Coder Social home page Coder Social logo

Comments (5)

JiuqingSong avatar JiuqingSong commented on June 12, 2024 1

Ok, this is because in demo site some content edit features are not enabled by default. Once enabled, this would work.
image

@juliaroldi I think we should only turn them off for content model demo site.

from roosterjs.

haven2world avatar haven2world commented on June 12, 2024

We fixed it by making the MaintainListChain edit feature asynchronous.
I'm not sure if RoosterJS maintainers want to fix it internally since the legacy editor is being deprecated.

import { ListFeatures } from 'roosterjs-editor-plugins/lib-mjs/plugins/ContentEdit/features/listFeatures';
import { GenericContentEditFeature, PluginKeyboardEvent } from 'roosterjs-editor-types';

// Run maintainListChain edit feature in async to fix the issue "The number of the new line is not increased after typing return"

const { maintainListChain } = ListFeatures;

/**
 * Maintain the list numbers in list chain
 * e.g. we have two lists:
 * 1, 2, 3 and 4, 5, 6
 * Now we delete list item 2, so the first one becomes "1, 2".
 * This edit feature can maintain the list number of the second list to become "3, 4, 5"
 */
export const AsyncMaintainListChain: GenericContentEditFeature<PluginKeyboardEvent> = {
  keys: maintainListChain.keys,
  shouldHandleEvent: maintainListChain.shouldHandleEvent,
  handleEvent: (event, editor) => {
    setTimeout(() => {
      maintainListChain.handleEvent(event, editor);
    }, 50);
  },
};

from roosterjs.

vhuseinova-msft avatar vhuseinova-msft commented on June 12, 2024

Hi @haven2world,
I see, thank you very much for sharing the code!

from roosterjs.

JiuqingSong avatar JiuqingSong commented on June 12, 2024

@juliaroldi can you take a look? The recent change should not impact legacy editor, but I remember this should work not too long ago.

from roosterjs.

JiuqingSong avatar JiuqingSong commented on June 12, 2024

#2439

from roosterjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.