Coder Social home page Coder Social logo

Comments (5)

JiuqingSong avatar JiuqingSong commented on June 12, 2024

What is the end to end repro ste? @Rain-Zheng

from roosterjs.

Rain-Zheng avatar Rain-Zheng commented on June 12, 2024

@JiuqingSong I can't directly repro it in demo site because it needs a custom element processor, so I create a local build to repro:

  1. Create a custom div processor and add it to editor option:
image
  1. Update the editor's initial content. The content contains 2 div elements, with id and without id:
image
  1. Run the demo, check the elements:
image image

from roosterjs.

JiuqingSong avatar JiuqingSong commented on June 12, 2024

@Rain-Zheng please feel free to push a branch with your code change so I can debug with it.

Question: When and how do you switch to dark mode?

from roosterjs.

Rain-Zheng avatar Rain-Zheng commented on June 12, 2024

@JiuqingSong I created a branch here: https://github.com/Rain-Zheng/roosterjs/tree/test/general_block_dark_mode

The issue only exists when the default editor style is dark mode. If it's switched from light to dark, the element will be transformed correctly.

from roosterjs.

JiuqingSong avatar JiuqingSong commented on June 12, 2024

Good finding. Here is a fix #2397

(Still need to add more test cases)

from roosterjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.