Output file names from Split-StigXccdf aren't consistent with ConvertTo-PowerStigXml about powerstig

[athaynes]

Good find. I am wondering if we should change the way we build the output file name by using the xccdf content instead of the file name. That way we have a single function to use going forward. There is some old code in Get-OutputFileRoot that references the composite DSC resource that needs to be removed as well.

I am thinking that we add a function called Get-OutputFileName that extracts the name from the benchmark in the format we want. (Technology-TechnologyVersion-TechnologyRole*-StigVersion). Then we rename Get-OutputFileRoot to Get-OutputFileList, that will build and return the full path to the STIG and Org settings file as a hashtable.

Returning the partial path and updating is here https://github.com/Microsoft/PowerStig/blob/fa732a5a3ed84ec8c9f1d197deae5e6d0fc359bb/Module/Convert.Main/Functions.PowerStigXml.ps1#L203

doesn't make much sense and as you identified causes additional problems.

@jcwalker @regedit32 Any feedback on this?

[jcwalker]

We actually have a story on our backlog for this. I think a consistent naming convention is a must and if we can make that automated...even better.

[athaynes]

Thanks, I opened a PR to address this.

#23