microsoft / mu_oem_sample

Project Mu OEM Sample Code

Project Mu Oem Sample Repository

Host Type & Toolchain	Build Status	Test Status	Code Coverage
Windows_VS
Ubuntu_GCC5

This repository is part of Project Mu. Please see Project Mu for details https://microsoft.github.io/mu

Branch Status - release/202311

Status

In Development

Entered Development

Dec 2023

Anticipated Stabilization

Feb 2024

Branch Changes - release/202311

Breaking Changes-dev

• Incomplete

Main Changes-dev

• Incomplete

Bug Fixes-dev

• Incomplete

Branched from 202302

Commit: b340920dce8c0cd7c87865386ae8dc53ecf230e0

Code of Conduct

This project has adopted the Microsoft Open Source Code of Conduct https://opensource.microsoft.com/codeofconduct/

For more information see the Code of Conduct FAQ https://opensource.microsoft.com/codeofconduct/faq/ or contact [email protected]. with any additional questions or comments.

Contributions

Contributions are always welcome and encouraged! Please open any issues in the Project Mu GitHub tracker and read https://microsoft.github.io/mu/How/contributing/

Copyright & License

Copyright (C) Microsoft Corporation
SPDX-License-Identifier: BSD-2-Clause-Patent

mu_oem_sample's Issues

[Bug]: Building for AARCH64 for OemPkg does not link stack cookies

Is there an existing issue for this?

• I have searched existing issues

Current Behavior

If you attempt to build OemPkg using stuart_ci_build with GCC on WSL2 for AARCH64 you will see the be met with linker errors

Expected Behavior

OemPkg should be built correctly

Steps To Reproduce

1. Create a WSL2 Environment to build Project MU
2. Clone this repo
3. stuart_ci_setup -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5
4. stuart_update -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5
5. stuart_ci_build -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5

Build Environment

- OS(s):
   - WSL2 Ubuntu 22.04.2
- Tool Chain(s):
   - GCC5
- Targets Impacted:
   - AARCH64

Version Information

release/202302 and below

Urgency

Low

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

[Bug]: DFCI_CertChainingTest report fail when manufacturing mode

Is there an existing issue for this?

• I have searched existing issues

Current Behavior

Follow the implementation of DfciUiDisplayAuthDialog function, DFCI_CertChainingTest reports 5 Fails when manufacturing mode.

DfciUiDisplayAuthDialog function will accept the enrollment without the proper key when manufacturing mode.

Expected Behavior

mu_oem_sample should provide the sample code which can pass all DFCI test cases.

Should the DfciUiDisplayAuthDialog function be changed as below:

  if (DfciUiIsManufacturingMode ()) {
    *Result = DFCI_MB_IDCANCEL;
    return EFI_SUCCESS;
  }

Steps To Reproduce

BOOLEAN
EFIAPI
DfciUiIsManufacturingMode (
  VOID
  ) {
  return TRUE;
}

2. Run DFCI_CertChainingTest test case and it will report 5 Fails.

Build Environment

- OS(s): Windows 10
- Tool Chain(s): VS2019
- Targets Impacted:RELEASE

Version Information

Commit: 1709eca4a7e17372b9d0c801cbd1fa8e7cbf7b83

Urgency

Medium

Are you going to fix this?

Someone else needs to fix it

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

No response

This repo is missing important files

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

[Bug]: Intune uses Type 01 serial number for 4k hash, DfciIdSupportGetSerialNumber should match expected serial number type

Is there an existing issue for this?

• I have searched existing issues

Current Behavior

The current behavior is DfciIdSupportGetSerialNumber return the type 03 serial number instead of the intune expected serial number of type 01

https://github.com/microsoft/mu_oem_sample/blob/9174bf2dfa6f339633deefa28747097fb04b43fc/OemPkg/Library/DfciDeviceIdSupportLib/DfciDeviceIdSupportLib.c#LL209C1-L210C1

For example of what Intune expects see:
https://www.powershellgallery.com/packages/Get-WindowsAutoPilotInfo/3.5/Content/Get-WindowsAutoPilotInfo.ps1

Expected Behavior

DfciIdSupportGetSerialNumber should return type 01 serial number

Steps To Reproduce

Set the Type 01 and Type 03 serial numbers to different values
call DfciIdSupportGetSerialNumber and compare against

Get-CimInstance -ClassName Win32_BIOS -Property SerialNumber  | Select-Object -ExpandProperty SerialNumber

Build Environment

- OS(s): Windows 11
- Tool Chain(s): VS2022
- Targets Impacted: RELEASE

Version Information

v2023020000.0.0

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response