Remove git-lfs? about fluentdarkmodekit

[li-bei]

It seems ResearchKit will ignore lfs files for clone and pull: https://github.com/ResearchKit/ResearchKit/blob/master/.lfsconfig

Looks like a nice solution.

[imWildCat]

Can we refer to this image by dragging it into issues textarea then get the URL of this image?

[imWildCat]

Another reference is that: ResearchKit does have git-lfs: https://github.com/researchkit/researchkit

[icodesign]

I would say this is more of an Apple issue. I encountered it a lot when using other packages as well. Even we removed this file, there's no guarantee that we wouldn't add another file and it's not a good idea to ask contributors to stop using Git LFS (the right thing).

If you're going to use SPM, you're gonna face this issue until Apple fix it. Otherwise, Carthage/CocoaPods are still options.

I tend not to fix from our side as long as we've provided enough information.

[levinli303]

Removing LFS might not be very viable, since it is already in the history. If there are devs who are trying to fetch an earlier version from Xcode, the same thing would still happen.

[icodesign]

TIL. That's decent.

[levinli303]

I created a branch with this commit, however the issue did not get resolved when I was using Xcode to fetch it as a swift package (specifying the branch name as exclude-lfs-on-clone).

The difference that creating .lfsconfig excluding files makes is that it will prevent lfs files being resolved, but git-lfs will still get called, I think due to .gitattribute.

There might not be a way to work around this on machines without git-lfs.

[li-bei]

@eyvallah I guess Xcode will clone all branches and check out to your specified branch, only one branch with .lfsconfig seems not enough.

[levinli303]

Now I'm having no issue with the spm inside latest Xcode now even without the symbolic link hack, lfs files were simply not resolved and that is ideal. But I'm not sure if it works for everyone now.

[icodesign]

I checked and still need the hack.

[icodesign]

The error above is because that the script Apple is using doesn't include /usr/local/bin in its path while git-lfs is put under that path for most of us.

I think we can skip it since it's not an issue of this repo.

[levinli303]

Let's close this for now.