Comments (8)
We generally wait until a month after a release before changing any packages on DefinitelyTyped. This gives people time to upgrade to the new TypeScript version before packages start requiring it.
Based on that we should enable ts2.3 support on May 27.
from dtslint.
Thanks for the info @andy-ms
I was not aware of this practice.
Do you prefer if I close che PR on DT and reopen them in a month time, or should I just leave them open?
from dtslint.
It's up to you.
from dtslint.
Ok, I'll leave them open and reference this issue.
Thanks
from dtslint.
Do we have to have this rule in place across all packages instead of just existing ones? Seems like if a declaration file doesn't exist, there's no reason to keep the restriction in place.
from dtslint.
That would be nice but the way dtslint is designed, it doesn't distinguish between new/changed packages. I guess we could edit types-publisher to just look for the string // TypeScript Version: 2.3
on changed packages only, and have failures through that instead of dtslint.
from dtslint.
Yes, dtslint just failing on the header is likely confusing to contributors anyway.
from dtslint.
Shouldn't this waiting period be implemented in the type publisher?
According to the header it could only update the definition after the month, or alternatively it could publish the updated definition on a next
tag in npm and update the latest
tag only after a month.
This would avoid a large number of open PR on DT waiting for the end of waiting period and if the next
tag is used it would allow users to use the latest definitions if they so choose
I can open a related issue on https://github.com/Microsoft/types-publisher if it's more appropriate
from dtslint.
Related Issues (20)
- Deprecate `$ExpectError` in favour of `@ts‑expect‑error`
- yargs-parser causing protoype pollution vulnerability
- `no‑redundant‑jsdoc‑2` causes build failures in TypeScript@next even when no type information is present HOT 1
- Overriding default rules HOT 5
- run dtslint in watch mode? HOT 1
- Allow `@deprecated` JSDoc tags
- Investigating ESLint migration HOT 30
- discuss 'space-before-function-paren' setup according to DT devtool configuration
- Error on too-low `// Minimum TypeScript Version:`
- Typescript@next Errors when finding Promise HOT 1
- no-outside-dependencies false positive on 'buffer'
- Ability to use `esnext` module
- [Bug?] 'whitespace' rule threw an error. Line with `export * as` HOT 2
- [Bug] get different result of type inference depends on typescript version, but only one type is allowed as $ExpectType HOT 1
- Linting integration with monaco editor
- feedback about miss spell of $ExpectType
- dtslint doesn't support older versions that have minor version numbers HOT 3
- unified-signatures should allow signatures when at least one is deprecated
- expect-type should allow tsconfig options from new versions of typescript HOT 4
- $ExpectType ignoring namespace in TS4.7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dtslint.