Coder Social home page Coder Social logo

Comments (8)

 avatar commented on June 2, 2024

We generally wait until a month after a release before changing any packages on DefinitelyTyped. This gives people time to upgrade to the new TypeScript version before packages start requiring it.
Based on that we should enable ts2.3 support on May 27.

from dtslint.

CaselIT avatar CaselIT commented on June 2, 2024

Thanks for the info @andy-ms
I was not aware of this practice.
Do you prefer if I close che PR on DT and reopen them in a month time, or should I just leave them open?

from dtslint.

 avatar commented on June 2, 2024

It's up to you.

from dtslint.

CaselIT avatar CaselIT commented on June 2, 2024

Ok, I'll leave them open and reference this issue.

Thanks

from dtslint.

DanielRosenwasser avatar DanielRosenwasser commented on June 2, 2024

Do we have to have this rule in place across all packages instead of just existing ones? Seems like if a declaration file doesn't exist, there's no reason to keep the restriction in place.

from dtslint.

 avatar commented on June 2, 2024

That would be nice but the way dtslint is designed, it doesn't distinguish between new/changed packages. I guess we could edit types-publisher to just look for the string // TypeScript Version: 2.3 on changed packages only, and have failures through that instead of dtslint.

from dtslint.

DanielRosenwasser avatar DanielRosenwasser commented on June 2, 2024

Yes, dtslint just failing on the header is likely confusing to contributors anyway.

from dtslint.

CaselIT avatar CaselIT commented on June 2, 2024

Shouldn't this waiting period be implemented in the type publisher?
According to the header it could only update the definition after the month, or alternatively it could publish the updated definition on a next tag in npm and update the latest tag only after a month.
This would avoid a large number of open PR on DT waiting for the end of waiting period and if the next tag is used it would allow users to use the latest definitions if they so choose

I can open a related issue on https://github.com/Microsoft/types-publisher if it's more appropriate

from dtslint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.