Coder Social home page Coder Social logo

Overriding default rules about dtslint HOT 5 OPEN

ubbe-xyz avatar ubbe-xyz commented on July 18, 2024 3
Overriding default rules

from dtslint.

Comments (5)

afontcu avatar afontcu commented on July 18, 2024 3

Hi! Stumbled upon this issue because I'm facing the same problem – a broken CI pipeline due to a dependency using ts-ignore. Has anyone found a valid workaround? 😃 Adding a local tslint.json and disabling the check did not work.

from dtslint.

orta avatar orta commented on July 18, 2024

We shouldn't raise errors like this for .d.ts files inside node_modules IMO

from dtslint.

Haroenv avatar Haroenv commented on July 18, 2024

Where would the code be for that?

dtslint/src/lint.ts

Lines 51 to 55 in 285e5a9

if (!isExternalDependency(file, dirPath, lintProgram) &&
(inTypesVersionDirectory || !isTypesVersionPath(fileName, dirPath))) {
linter.lint(fileName, text, config);
}
}

but then add it behind a feature flag to not lint "dependencies" at all? Or am I misunderstanding the code?

from dtslint.

orta avatar orta commented on July 18, 2024

It looks like there's some intentional code under that to run linters against external code - @sandersn any idea what the goal for that is?

from dtslint.

JounQin avatar JounQin commented on July 18, 2024

related #89 (comment)

from dtslint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.