microsoft / dotnet-framework-docker-samples

The .NET Framework Docker samples have moved to https://github.com/Microsoft/dotnet-framework-docker

The .NET Core Docker samples have moved to the samples folder of Microsoft/dotnet-framework-docker.

dotnet-framework-docker-samples's Issues

This example page is for .net framework

And the example says build for .net core.

I dont want to build that, because I have a few million lines of code already written in netfx.

Use .NET 3.5 build image for building .NET 3.5 project

This depends on :
microsoft/dotnet-framework-docker#48

.NET Framework Docker Samples have moved

.NET Framework Docker Samples have moved

The .NET Framework Docker samples have moved to the samples folder of Microsoft/dotnet-framework-docker.

Details

The .NET Framework Docker samples have been enhanced and moved to the samples folder of Microsoft/dotnet-framework-docker.

• microsoft/dotnet-framework-docker#126
• #22

The samples show various ways to use the .NET Framework and Docker together. You can use the samples as the basis of your own Docker images or just to play.

The samples exercise various levels of functionality. The .NET Framework Docker sample includes the most functionality, including build, unit testing, and pushing images to a container registry. The ASP.NET Docker sample includes instructions for testing images with Azure Container Instances. The samples include detailed instructions for use with and without Docker.

Convert dotnetapp sample projects for dockerhub to SDK style

I'm getting image not found locally

ran the 'docker build -t app-app .' command
no errors:

PS E:\Development\docker\dotnet-framework-docker-samples\dotnetapp-4.6.2> docker build -t my-app .
Sending build context to Docker daemon 214 kB
Step 1/4 : FROM microsoft/dotnet-framework:4.6.2
4.6.2: Pulling from microsoft/dotnet-framework
3889bb8d808b: Pulling fs layer
423d66441981: Downloading
unknown blob

then docker run my-app returns

Unable to find image 'my-app:latest' locally

CMD to add Git in building container

I would like to see if we can use CMD to install Git to our own image ?

For example :

WORKDIR /app
CMD '.\Git-2.10.2-64-bit.exe /silent /suppressmsgboxes /dir="c:\git64" /log="git64.log"' ?

Or we can add the Git exe to the container and run
the silent installation after starting the container ?

Thanks

Ken

Github Url for dotnetapp-4.7 sample is Incorrect

The URI given in Readme.md for the dotnetapp-4.7 is Incorrect

Git clone this repository or otherwise copy this sample to your machine: git clone
https://github.com/dotnet/dotnet-framework-docker-samples/dotnetapp-4.7

Build and publish images using buildpipeline and image builder tool

getting the error dotnet is not recognized

Getting the following error when i do >docker build -t my-dotnet462-app .

Sending build context to Docker daemon 873.5kB
Step 1/8 : FROM microsoft/dotnet-framework:4.6.2
---> 6a26127feff4
Step 2/8 : WORKDIR /app
---> Using cache
---> e670ba63085d
Step 3/8 : COPY *.csproj ./
---> Using cache
---> 9172c87fac16
Step 4/8 : RUN dotnet restore
---> Running in c8f7abfff5c1
'dotnet' is not recognized as an internal or external command,
operable program or batch file.
The command 'cmd /S /C dotnet restore' returned a non-zero code: 1

'dotnet' is not recognized as an internal or external command,
operable program or batch file.

Merge DockerHub branch into Master

The samples that are pushed to Docker Hub should be built from the main samples in the master branch. This will help ensure the samples pushed to Docker Hub are same samples shown in master. Right now the samples in master are not using multi-stage Dockerfiles whereas the samples in the dockerhub branch are.

Consider merging the microsoft/dotnet-framework-docker-samples GitHub repo into the microsoft/dotnet-framework-docker GitHub repo

The primary motivation behind this change is visibility. The belief is that having all assets related to the microsoft/dotnet-framework Docker repo within one GitHub repo will help increase the visibility of everything. If a user navigates to from microsoft/dotnet-framework to the microsoft/dotnet-framework-docker GitHub repo to view the Dockerfiles, there is a higher chance they will see the samples if there are within the same repo. Having the samples in the same GitHub repo as the Dockerfiles will also help increase the visibility of incoming issues and PRs related to the samples.

The samples do cover usage scenarios beyond microsoft/dotnet-framework. For example the samples cover aspnet and wcf. This could be viewed as a positive as ASP.NET and WCF are based on the full .NET FX images. Seeing the ASP.NET and WCF samples could help bring visibility to the fact that the those images exist and are based on the .NET FX images.