mickaelrigault / pyifu Goto Github PK

Hi, in .../pyifu/adr.py line 426, the function "airmass_to_zd(airmass)" is supposed to return degrees but it seems to return the angles in radians.
Simple test: ADR.airmass_to_zd(ADR.zd_to_airmass(26)) doesn't returns 26 but ADR.airmass_to_zd(ADR.zd_to_airmass(26))*180/np.pi does.

This crashes any interactive session that uses pyifu (extractstar.py --display, e.g.) and matplotlib version > 3.2.2

Three interactive functions use this private attribute and must be updated to use Axes.get_navigate_mode() function instead:

OLD (currently crashes in interactive mode):
if self.fig.canvas.manager.toolbar._active is not None:
return

NEW (currently works):
for ax in self.fig.axes:
if ax.get_navigate_mode() is not None:
return
This may not be the most efficient way to use get_navigate_mode(), but it seems to work.

The functions in question are in pyifu/mplinteractive.py:

1. interact_onclick
2. interact_onrelease
3. interact_trackmotion