Getting "One or more keys had non-ASCII characters" about zippyjson

[Kalzem]

Ah I found something interesting.

It seems like the error is random.

From my gist example, I have tested by only taking the first item and removing the rest.

So I only have this left:

{
  "version": 1,
  "items": [
    {
      "id": "en_cat",
      "name": "cat",
      "lang": "en",
      "defs": [
        {
          "id": "en_cat_1",
          "def": "A cat is a domestic animal of the feline family.",
          "trans": {
            "fr": ["fr_chat_1"],
            "ru": ["ru_ко́шка_1"]
          },
          "ex": [
            "My cat is lazy and never hunts mice.",
            "Tigers are just very big cats."
          ]
        }
      ]
    }
  ]
}

It still doesn't work.

But if I change this:

    "trans": {
        "fr": ["fr_chat_1"],
        "ru": ["ru_ко́шка_1"]
      },

into

    "trans": {
        "fr": "fr_chat_1",
        "ru": "ru_ко́шка_1"
      },

it seems to be working...

Now I put back all the items from my initial gist and convert the array of Russian strings into just a Russian string (no array). It doesn't work anymore...

I do believe there is something wrong in how non-ascii characters are handled in the values (and not keys contrary to the error displayed).

[Kalzem]

Okay, last additional info:

I think there is something strange going on in this function: static inline bool JNTCheck(ParsedJson::iterator i)

The comment says Check if there are any non-ASCII chars in the dictionary keys, but I found out that it checks also values, not only keys.

Especially this part:

For any ASCII value, it returns false, but for Russian values it returns true

(lldb) p i.get_string() // English value - returns false
(const char *) $1 = 0x00007fec448172b8 "fr_chat_1"
(lldb) p i.get_string() // Russian value - returns true
(const char *) $2 = 0x00007fec448172cd "ru_\xffffffd0\xffffffba\xffffffd0\xffffffbe\xffffffcc\xffffff81\xffffffd1\xffffff88\xffffffd0\xffffffba\xffffffd0\xffffffb0_1"

What is the purpose of this check? If I deactivate it, everything is correctly parsed.

[michaeleisel]

Which version of the library are you using, and how did you install it?

[Kalzem]

I am using 0.0.5 with Cocoapods.

[michaeleisel]

yes, this is a legitimate bug. thank you for all the info! i've put a fix in, michaeleisel/ZippyJSONCFamily@100e71b

[michaeleisel]

actually michaeleisel/ZippyJSONCFamily@2b60469