michaelahlers / angular-timezones Goto Github PK

With bower, installation is failing on Windows because of a full path being hard-coded in the list of dependencies:

The following:

{
  "dependencies" : {
    ...
    "timezone-js" : "[email protected]:mde/timezone-js.git#v0.4.4"
  }
}

should be replaced by something like (as other dependencies):

{
  "dependencies" : {
    ...
    "timezone-js" : "0.4.4"
  }
}

Testing locally it works like a charm.

Some lightweight unit testing is appropriate, especially with some refactoring I'd like to do.

It is possible to load timezone files from alternate locations (this is especially important when using in nested paths), but the feature's currently undocumented. Refer to tzDateSpec.js for a current usage.

Introduce a service method that can be used to resolve Olson names and abbreviations to complete timezone definitions objects that include (among other fields) the offset, printable label, abbreviation (e.g., EST, CDT). This will be useful to future additions, such as timezone pickers.

Greetings!... i've been using this great module on a project without any problems, until i minified the app. I'm using $filter('tzAlign') but this gives

Error: [$injector:unpr] Unknown provider: aProvider <- a <- tzAlignFilter

The weird thing is that i inspected the minified js and the tzAlign filter is declared. Other filters like uppercase are working fine. I guess that ultimately i could use the unminified version of the module, at least no mangled, but i'm trying to reduce the load time of the app. So, what other solution may be?

Make it easier to configure the timezone data sources, and track more closely with AngularJS module configuration guidelines.

There is a rarely used, obscure timezone simply called "Factory" that acts as a synonym for GMT offset 0. Arthur David Olson describes it as follows.

For companies who don't want to put time zone specification in their installation procedures. When users run date, they'll get the message. Also useful for the "comp.sources" version.

This will require some special cases, but is so rarely used that we won't support or test for it now.

I would like to use angular-timezones in my project, but I don't want to do a code theft. Could you add a license file or just a license info so that we know how could we use that library?

The $timezones.resolve function incorrectly inverts timezone offset values. This value is the difference between UTC and local time. If the offset is positive, the local time is behind UTC, and vice versa. See ECMA-262 §15.9.5.26 and Date.getTimezoneOffset.