michael-cohen-io / pokejava Goto Github PK

This is fantastic to see.

Might I suggest when you're done, adding a short "quick start" in the README?

Something similar to pykemon 👍

There's something that I don't find correct in the methods like Type.getResistance

If the resistance list is empty, it returns a null pointer, I found this really annoying while using the library. The list is already created, so why not return the empty list and avoid a null pointer exception when using a for loop on this list? If there's a reason then I'd like to know.

Thank you for reading and for the hard work!

Note: bear in mind that right now the PokeAPI doesn't include the type resistance information

I don't know how to get started with this

Hi there! I'm always getting an SSLHandshakeException when trying to receive any data. Any idea what could be causing that and how to fix this? I tested the url in the browser and it worked fine (after exchanging "v1" with "v2".

I'm getting this error on the Pokemon constructor depending on the ID I use as argument:

org.json.JSONException: JSONObject["level"] not found.
at org.json.JSONObject.get(JSONObject.java:454)
at org.json.JSONObject.getInt(JSONObject.java:514)
at com.pokejava.Pokemon.initializePokemon(Pokemon.java:169)
at com.pokejava.Pokemon.(Pokemon.java:48)
at main.Main.main(Main.java:47)
org.apache.http.client.HttpResponseException: NOT FOUND

Anyone knows how to fix it?

I've added the links to Descriptions in the Pokemon resource.
They follow the same style as evolutions, moves, abilities and types:

[
    {
        "name": "bulbasaur_gen_1",
    "resource_uri": "/api/v1/description/2/"
    },
    {
    "name": "bulbasaur_gen_2",
    "resource_uri": "/api/v1/description/3/"
    }
]

Just a suggestion that you might want to update your wrapper to include it!