Coder Social home page Coder Social logo

booksidian_plugin's Issues

Using the original page (Goodreads link) in a property

I have been using the link to the original page within the Content of the book-note section. Is there anyway to add this to the properties instead. As the field is available ie {{id}} I would imagine it would not be too complicated to add it to the 18 existing fields.

I am currently manually moving it from the note to the Property but it would be great if it could arrive in the right place. Thanks

Incorrect shelf data being pulled through

When syncing notes from my feed, some notes come through with the correct bookshelves but others come with additional bookshelves that they are not a part of on my goodreads. I have my goodreads shelf set up as an exclusive shelf so that 'read' or 'to-read' should not apply to any of those books, yet when I sync them to Obsidian they include 'to-read'.

image

image

It happens whether the book is on an exclusive shelf, and it even happens when changing the books to the 'read' shelf on Goodreads.

Booksidian discards punctuation marks

It seems that Booksidian discards punctuation marks when importing titles from the feed. This causes the creation of a duplicate note with a similar title to one already created some time ago. To explain further, I now have two notes with similar titles. One is entitled (in Italian) 'Detto, fatto! L'arte di fare bene le cose", imported months ago. Now, if I synchronise my feed, a new note is created 'Detto fatto! Larte di fare bene le cose', without a comma and without an apostrophe. This also happens with other books.

Incorrect Published Date

I have spent a couple of hours bringing in books and I have noticed that there is regularly a problem with the published date.

For instance the current book shows this in GoodReads: Published May 18th 2017 by HarperCollins (first published May 9th 2017)

But the date produced is: 2017-01-01

Make fetcher use lowercase shelf names

As goodreads shelfs are case-sensitive, adding information about it in Settings and Readme might be helpful.

Since shelves are lowercase querying goodreads for a shelf with the wrong name, it is the same as querying without specifying the shelf (see comment below)

Add plot option

Hey man, I love this plugin!
I'm very lazy and I'd love for the plot to be an option too. Is this possible?

Also I noticed that pages was not in the available fields(/placeholders) but it is possible to call it (It works when I sync) and i also saw u wrote code for it. Maybe add it so people don't miss it?

Books with special characters are not created

If the book has a character, that is not supported by the filesystem for files (typically ? : * / \ " |), the file is never created if it should appear in the file name.

For example if I have in the shelve this book: https://www.goodreads.com/book/show/21413662-what-if-serious-scientific-answers-to-absurd-hypothetical-questions and want to have the file named {{title}}, it is never downloaded.

I suggest create a setting (with default to -), for character to replace these special ones, so the file can be created.

Thank you!

Lack of Support for iPhone 15 Pro (iOS 17.4.1)

Obsidian on my iPhone had become very unstable and slow, and I believe I've narrowed the problem to Booksidian by toggling community plugins on and off. After updating to the latest Booksidian, I see a notice that it doesn't support my device.

image

Are there plans to add iPhone support? I love the plugin and use it regularly, so I'd love to see this happen. Also happy to pitch in with a PR or two if we know where the key issues are.

Update Base URL to only accept the correct URL

The Base URL input should automatically capture the required parameters.

The accepted URL as mentioned in the readme is https://www.goodreads.com/review/list_rss/<USER_ID>?key=<MY_KEY>&shelf=, whereas everything after &shelf= should be omitted as it will be handled by the Your Goodread shelfs option.

I think doing a regex capture of the above URL and stripping off anything else would help reducing the chance of mistakes (e.g #14).

Reaching out, interested in supporting the project

Hello @MichaBrugger ! Thanks for the great work on this plugin.

If you're still around and interested in getting some help with it, I have a few features I've implemented on a personal fork: zacharyw@717db15

  1. Automatic syncing
  2. Option to overwrite existing notes (so that changes in Goodreads, like adding a rating to a book that's already been synced will be picked up)

I actually forked off of @riccardopinto 's open PR to pick up their filename fixes. Initially I was just going to make some changes for personal use but I'd like to get them into the main plugin if possible.

A link back to Goodreads

I was just thinking it would be really helpful if there was a way to add a link back to the Goodreads page from your book note, A link within the page would be better than in the Yaml so you can click straight through.

I don't know if that would be too complicated though...

Feature Request: Abstract and review

This is my template I have set up:
`# {{title}}
Subtitle:: {{subtitle}}
series {{series}}
Cover

Abstract

My Thoughts

📨 Additional Metadata

🏷 Tags

  • 🗂Type:: #source/book📚
  • 🗣 Subject::
  • 🌍Area::
  • 🏁Status::
  • 💻Platform::
  • 📆dates:: {{datePublished}} (Published) {{dateRead}} Read
  • 👤author:: {{author}}
  • 👨‍👩‍👧‍👦 people::
  • ⭐ rating::
    `
    I leave the rating in the front matter because I swap it to a star system in the metadata. Would it be remotely possible for there to be a field for the Abstract blurb. At the moment I am copying them over one by one but it would be amazing if the could be brought in. The Chrome extension for booksidian uses the abstract field so I'm assuming it is available for anyone to use. Thank you in advance.

Sync Issue

Attempting to Sync to run everything. It sends up a hot key is not set yet. I've set a hotkey and all other settings appear to be correct and in proper format. I'm pointing to a specific folder not the default. I'm unable to run the plugin.

Sync Issue

When I add a book to an additional shelve on Goodreads, the Obsidian file is not updated, even as the RSS feed shows the additional shelve.

Generated YAML can be invalid

The generated YAML shown below is invalid:

---
author: James S.A. Corey
title: Leviathan Wakes
series: Expanse, #1
---

The issue is with the series field as the # needs to be quoted to be valid YAML. One simple solution might be to quote all values in getFrontmatterLines, or make the default prefix and suffix quotes.

Add release notes to Releases

It would be nice to easily see what changes (issues / new features) when a new version is released.
I've already updated the releases I've done so far manually, but adding generateReleaseNotes to the create-release action will do this automatically 🙂

{{cover}} attribute no longer working

The {{cover}} attribute is no longer being parsed correctly by Obsidian. Maybe it's a result of recent changes to Obsidian?

I get this:
![Cover](https:&#x2F;&#x2F;i.gr-assets.com&#x2F;images&#x2F;S&#x2F;compressed.photo.goodreads.com&#x2F;books&#x2F;1675653942l&#x2F;60766189._SY475_.jpg)

Instead of this:
![Cover](https://images-na.ssl-images-amazon.com/images/S/compressed.photo.goodreads.com/books/1675653942i/60766189.jpg)

Sync Issues

I am having problems again with syncing. I have made no changed at the Obsidian end. All I am doing is going through my GoodReads Books and adding to-obsidian (which is my import folder) to small collections. The biggest has been about 12 books. I'm finding it will do a batch. Then when I try to do the next - maybe ten mins later approximately. When I go to sync nothing happens.

I don't know if this is the plugin or does it take a while for the Goodreads RSS to know that a new shelf has been added at their end?

Update: I tested this out and changed my sync shelf to a long established shelf with three books on and that worked. I don't know how long would be best to leave it between adding the shelf and doing the sync? Thanks

Categorization of shelves

When i sync all books, to an empty folder, the field for shelves populates correctly for the shelves: to-read, and currently-reading, but is left blank for all books in the read shelf.

Non-English titles with some symbols aren't parsing

Hi! Thank you for this plugin. But I have an issue with parsing non-English titles. When I import these books in the obsidian, there are only English letters and numbers in the titles.

But it must be "C# 4.0: полное руководство". '#', '.', ':' and all Cyrillic symbols are skipped.

Problem when running Templater's trigger option in Booksidian.

Hello. First of all, thank you for this great plugin. The plugin works just fine. However, I would like to share with you a problem I encountered. I am using "templater" and "dataview" plugin in "content of the book note" section. Here is the content I entered in this section:

{{title}}
yazar:: #<% tp.frontmatter.author %>
kategori:: #<% tp.frontmatter.shelves %>

table without id ("![|250](" + cover +")") as Cover, yazar as Yazar, rating as Rating_My, avgRating as Rating_G, kategori as Kategori 
from "<% tp.file.folder(true) %>/<% tp.file.title %>"
where cover != null
sort rating desc

My goal is to show in a table information such as the cover illustration of the relevant book, my own rating, the rating and category of the Goodreads community.
The Templater plugin codes I use here work exactly as I want. However, an interesting problem arises if I run the "trigger" feature in the Templater plugin settings. The book information on my list is getting mixed up.
For example, let's say I'm pulling information from a science fiction shelf. I have books A, B, C, D... on my Sci-Fi Shelf. I'm importing into my obsidian vault with the Booksidian plugin. If the Templater trigger is not turned on, I go into each book file on my shelf and run the templater codes manually. No problem.
But if you have 50 books on your shelf, you have to repeat this 50 times.
In this case, the Templater trigger feature is a great solution. However, as I mentioned above, the information is mixed. For example, A book cover picture B is B cover C, D or someone else.
I'm not a professional expert, but I think things get messy when fetching cover images from the internet. It would be great if a method could be found to fix this problem.
I'm very new to Github. I hope I wrote it in the right place.

Other bookshelves being imported

I have left my Obsidian settings to just import my currently-reading shelf which has five books in it. However, when I sync'd it there were several imported including to-read shelves and read books. There is a good chance I will want to import all my books but into different areas of my vault depending on the theme etc
CleanShot 2022-07-04 at 2 30 59@2x

CleanShot 2022-07-04 at 2 35 16@2x

CleanShot 2022-07-04 at 2 32 21@2x

CleanShot 2022-07-04 at 2 31 29@2x

CleanShot 2022-07-04 at 2 33 28@2x

.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.