micahu-zz / splitter Goto Github PK

Handle remainder after dividing odd number by 2.
Choices to consider:
a. send it back
b. store +=1 in the sender's account for future withdrawal
c. arbitrarily award it one of the recipients,
d. give it to the contract owner
e. reject all odd numbers

• getSplitterContract
  ...

Contract

• There are 3 people: Alice, Bob and Carol ([A], [B], [C]).
• When [A] sends ether to the contract, half goes to [B], half to [C].

User Interface

• [A] can send ether to the contract from the Web page.
• Web page shows the balance of the Splitter contract.
• Web page shows the balances of [A], [B], [C]

Open questions

(none)

Transfer control late by moving anything affording chances at re-entry, that is, any implicit transfer of control. Order as such:

1. Optimistic accounting - get the contract state in order (including emit)
2. Then transfer flow control (call, send, transfer)
3. Check result and revert if needed

Consider Bob and Carol could be functions, so use a withdrawal, and/or approve/transferFrom flow. If Carol decides to revert (might be a contract), then would prevent (DoS) Bob from getting paid. And vice versa with Bob.

Still emit event so that they (UI?) can subscribe to the occurrence.
This will avoid contact with more than one "untrusted" contract at a time.

• test balance change on odd number deposits
• add balance test for carol