mhdirkse / codegen Goto Github PK

HandlerStackContext.removeAllPreceeding only takes into account the sequence number of the handler being visited. For example, if this is the third handler (sequence number 2), then two handlers are removed. However, if before the call to removeAllPreceeding there were other calculations, then the number to remove is different. For example, if removeFirst() was called before, then only one handler remains to be removed.

The class HandlerStubVisitorImpl calls a HandlerRunner instance. This HandlerRunner calls the right method on the generated handler interface; in the test this is HandlerStub. The testcode tests that the return value of HandlerRunner is properly used, but the interaction between the HandlerRunner and the HandlerStub is not tested. The code suggests otherwise, because the return value is specified in the constructor of HandlerStub.

In my Codegen program I has an annotation @input() where referenced the name of an inner class. The Codegen program gave an error when the inner class was referenced by its canonical name, which is without "$" sign. The plugin error was fixed when the class was referenced by its ordinary name, which is with "$" sign. But that way, I got a compile error in my output class. It inherited from , but now you do not need the "$" sign.

Too many classes have Visitor in their name. Naming has to be reconsidered.