Coder Social home page Coder Social logo

Comments (5)

wezzle avatar wezzle commented on May 14, 2024 1

@mg901 Thank you for your reply.

Ok, I get where it comes from now. Bootstrap 4 however uses different naming where it is more logical what functionality is used. They use media-breakpoint-down which gives you a breakpoint for the size you supply down from it's parent (larger) breakpoint. However even the first answer in your link "Bootstrap 4 - how to use media query mixin" seems to get this wrong, he says:

@include media-breakpoint-down(md) {} creates a breakpoint with a max-width of $md

Which is wrong, as in his case it gives a max-width of lg instead of md

When naming the function below the implied functionality would be that it gives a max-width of the supplied argument, not it's parent. So if this functionality is required I would propose naming the current below to down and create a new function below with the functionality as in my pull request #6

I would like to hear your thoughts on this

from styled-breakpoints.

mg901 avatar mg901 commented on May 14, 2024

@wezzle, thank you for your PR, and for using styled-breakpoints. To better understand how breakpoints work in styled-breakpoints, refer to the following sources.
Can not use below function on highest breakpoint
Bootstrap 4 - how to use media query mixin
Boostrap 4 breakpoints

from styled-breakpoints.

mg901 avatar mg901 commented on May 14, 2024

@wezzle Sorry for the long answer )). Thank you so much for using styled-breakpoints. I think that you are right and it is worth renaming the function below to down. In the near future I will do it. However, I see the need to add the function below with the function proposed by you, since the current API covers all the scenarios you described.

from styled-breakpoints.

sorosora avatar sorosora commented on May 14, 2024

I'm so expected to this updating. Please fix it 😄

from styled-breakpoints.

mg901 avatar mg901 commented on May 14, 2024

@sorosora Done!

from styled-breakpoints.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.