mfauzanalg / avatar-battle-card-game Goto Github PK

Look at this.

https://github.com/mfauzanalg/Tubes-2-OOP-CardGame/blob/fec1e1b69d75538230a32cf2c1c4168c184fbab3/src/main/java/com/avatarduel/component/AuraSkillCard.java#L6-L16

One day, if you are going to check the skill card, you have to code like skillCard.getEffect().equals("aura"). But wait, is it really "aura", "AURA", or "Aura"? Or maybe "AuraEffect"? This may lead to bigger bugs. Better if you have

class SkillCard {
  public static final String EFFECT_AURA = "aura";
}

// somewhere
    skillCard.getEffect().equals(SkillCard.EFFECT_AURA);

So if you wont get any typo. At least, if you type effect_aura, you will get compile error.

Moreover you can change the String to int, so you can have skillCard.getEffect() == SkillCard.EFFECT_AURA.

This issue is only a suggestion. You may argue with it (not all the suggestions are true), challenge it, or come up with another idea yourself. Please kindly close this issue after you feel this issue is irrelevant / solved.

You have attackPos and isPowerUp in your BoardCard. However, the only one with those two attribute is character. Why don't rename it to BoardCharacterCard ?

https://github.com/mfauzanalg/Tubes-2-OOP-CardGame/blob/fec1e1b69d75538230a32cf2c1c4168c184fbab3/src/main/java/com/avatarduel/component/BoardCard.java#L9-L19

This issue is only a suggestion. You may argue with it (not all the suggestions are true), challenge it, or come up with another idea yourself. Please kindly close this issue after you feel this issue is irrelevant / solved.