Coder Social home page Coder Social logo

PHP 8.1 Support about mezzio HOT 12 CLOSED

mezzio avatar mezzio commented on July 19, 2024
PHP 8.1 Support

from mezzio.

Comments (12)

agustingomes avatar agustingomes commented on July 19, 2024 2

I'll work the next days on the other 2 issues I opened, before proceeding further with the PR for this repository.

from mezzio.

froschdesign avatar froschdesign commented on July 19, 2024 1

@agustingomes
The support of PHP 8.1 can be added in a minor version which means for this package: 3.7.0. The related branch is 3.7.x.

from mezzio.

agustingomes avatar agustingomes commented on July 19, 2024 1

perfect. I'll invest some time for this today

from mezzio.

froschdesign avatar froschdesign commented on July 19, 2024 1

@agustingomes
See my comment on the pull request. 😉

from mezzio.

agustingomes avatar agustingomes commented on July 19, 2024 1

@shandyDev I took a brief look, but it seems it's not possible easily, since supporting 2.x now will entail some degree of refactoring, which I feel it's out of scope for PHP 8.1 support.

I would suggest to open a new issue, so the maintainers can assess if this request is feasible.

from mezzio.

mrVrAlex avatar mrVrAlex commented on July 19, 2024 1

Agree. httphandlerrunner 1.x have PHP 8.1 support, this should be separate issue.

from mezzio.

agustingomes avatar agustingomes commented on July 19, 2024

@boesing what should be the base branch in this case, 3.6.x or 4.0.x?

from mezzio.

agustingomes avatar agustingomes commented on July 19, 2024

I've ran updates to the composer.lock of the project, and what I found so far in the PR:

  • all the direct dependencies under require are ready for PHP 8.1
  • all the following dev dependencies need to be upgraded to be compatible with PHP 8.1
  • with E_ALL set for error_reporting some test are failing, but that is tied to the point above.

from mezzio.

agustingomes avatar agustingomes commented on July 19, 2024

@froschdesign I see some 7.3 tests fail. on e of the dependencies involved is laminas/laminas-servicemanager which is no longer compatible since 3.8.0, which is the same version that PHP 8.1 support was added for it.

Is this an indication we should drop PHP 7.3 as dependency?

from mezzio.

agustingomes avatar agustingomes commented on July 19, 2024

I removed support for 7.3.

Additionally I updated the coding standards package to be compatible with 8.1, but one of the sniffs of the 2.3.0 can introduce breaking code for 7.4.

Here is the explanation i added in the commit:

The exclusions added avoid breaking code to be added, since the sniff
targeted replaces occurrences of get_class($instance) by
$instance::class which is not compatible with PHP 7.4.

from mezzio.

mrVrAlex avatar mrVrAlex commented on July 19, 2024

What about support for laminas-httphandlerrunner 2.x versions? It is possible have support both 1.x && 2.x in composer?

from mezzio.

agustingomes avatar agustingomes commented on July 19, 2024

Closed with #96

from mezzio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.