[RFC]: Provide an ApplicationProgrammaticConfigDelegator that pairs with ApplicationConfigInjectionDelegator about mezzio

[acelaya]

Hey!

I had to read my original issue again, as I did not remember the context 😅

The thing is that, everything I described there, that motivated me to open this issue in the first place, was eventually rolled back, because it ended up introducing other issues (I won't describe them here, as it's unrelated).

But in essence, yeah, I think your proposal makes sense. Having everything related to routes bound to the router and not the application, is probably more intuitive.

I'll close this and watch the other issue for updates.

[acelaya]

Just as a comment. As a short term solution I have placed my pipeline and routes files inside a different folder (config/programmatic), that way I can have my own delegator factory that can be always safely used (even with swoole).

This would be an option to make this change in a fully backwards-compatible way.

[Ocramius]

Just removing the convention and moving the service to a factory would enable this 👍

[boesing]

The skeleton application would use this new delegator by default.

if that is the case, shouldn't we put this into the skeleton instead?
I'd rather get rid of the whole application delegator stuff and instead recommend to have properly targeted delegators instead.

When it comes to mezzio, laminas-cli uses the config/container.php which does not instantiate any application:

https://github.com/laminas/laminas-cli/blob/97930db3fd2550da0374a3ccbdc7f9b9d6177319/src/ContainerResolver.php#L55-L60

Now there are also CLI commands which do want to provide mezzio route tables: mezzio/mezzio-tooling#27

So this CLI command would preferably do something like:

$registeredRoutes = $container->get(RouteCollectorInterface::class)->getRoutes();
foreach ($registeredRoutes as $route) {
    // create table
}

https://github.com/mezzio/mezzio-router/blob/182d47967b955f20adbb072526bac50300fa7dcb/src/RouteCollectorInterface.php#L89

But due to these application delegators, it actually has to do stuff like:

$container->get(Application::class);
$registeredRoutes = $container->get(RouteCollectorInterface::class)->getRoutes();
foreach ($registeredRoutes as $route) {
    // create table
}

---

That is why I proposed to get rid of the existing decorator in #147 and to provide new decorators for both RouteCollectorInterface and MiddlewarePipeInterface which are replacing the existing decorator in #154.

WDYT?