meyadd / javascript Goto Github PK

Well done! 🎉

I especially like your clean and complete solutions, like ass. 9
Assignment 13 is also really well done!
It looks like these assignments might not be challenging enough for you. If you need extra challenges let us know.

We expected people to just write each object inside an array but this is a much better solution. Now if you could just write a function called createLlElement(innerText) that you call for each item in the array for assignment 3(and have that use create and append) you could combine the best of both worlds :)

Hi @meyadd .
To assign you fellow students for the checkup about the feedback, please create an issue wherein you "assign" them all to an issue of a different assignment like I did here. Let me know if something is unclear.

I overwrites the whole document so it's not very useful for pages that already have some HTML. It's better to either add the HTML string or use appendChild (preferred method)/

Hi Eyad.
To assign you fellow students for the checkup about the feedback, please create an issue wherein you "assign" them all to an issue of a different assignment like I did here. Let me know if something is unclear.

You're generating an HTML string which you inject/write in the HTML. That's a lot more buggy and messy than using createElement and appendChild. It's not a mistake but I would recommend you to try the other was as it is more Object Oriented approach.

Good job overall. I really like how you used functions and their return values and even made function calls from within other functions. Pretty awesome 🥇