Comments (7)
Given automatic refreshing in RStudio, I'm guessing your feeling is that RStudio users will find these more useful than tail_output and tail_lst?
Exactly. I talked to a few folks at ACoP who were not finding the tail_
helpers that... helpful. And one of them gave me this idea, which I think is a good one.
from bbr.
@kyleam I'm considering trying to sneak in a small bbr
release before the next MPN, basically with what I put on https://github.com/metrumresearchgroup/bbr/milestone/28 , and I'm interested in your thoughts. I'm commenting on this issue because I think it is the one that has the potential to get complicated (though I hope not).
My primary motivation here is that we are planning to update the Expo repo to the newest MPN, after the next snapshot, and I would like to be able mention the new open_*
helpers (this one and #570 that already merged).
Any thoughts on this are welcome, but the things on my mind currently are:
- Are there any complicating factors in this issue that I'm not thinking of?
- Should this be
1.6.0
or1.5.1
? - Is there anything else little that we should knock out and include? I looked over the open issues and didn't spot anything, but I may have missed something.
Relevant: #570 is the only that's merged to main
since 1.5.0
.
from bbr.
primarily for monitoring runs in progress
Given automatic refreshing in RStudio, I'm guessing your feeling is that RStudio users will find these more useful than tail_output
and tail_lst
?
from bbr.
Are there any complicating factors in this issue that I'm not thinking of?
Nothing's popping out to me. The main thing is that it's probably worth reviewing R/read-output.R
to try to avoid having duplicate internal logic.
Should this be
1.6.0
or1.5.1
?
I'd say 1.6.0 because it'd have new features.
Is there anything else little that we should knock out and include?
I can't think of anything that need to be prioritized for this release.
from bbr.
@seth127 Just making a note of it since I didnt see an issue for it, but we may want to include the model_summary() bug for when no directory exists. I know you said you didnt run into this issue at one point on your machine, but may be worth testing for the next release
from bbr.
We're going to hold off on this release for now (probably another week or two, at least) because of other priorities. On this...
the model_summary() bug for when no directory exists.
As you note, I wasn't able to reproduce it with the newest bbr
, but I may have been doing something different. See you can reproduce it outside of the diagnostics apps context and, if you can, go ahead and make an issue.
FWIW, I tried to reproduce the error with this and couldn't:
devtools::load_all()
.md <- system.file("model", "nonmem", "basic", package = "bbr")
mod1 <- read_model(file.path(.md, 1))
mod2 <- copy_model_from(mod1)
# these all work for me
summary_log(.md)
run_log(.md) %>% add_summary()
model_summaries(list(mod1, mod2))
# this fails, but that's fine
model_summary(mod2)
# Error in get_output_dir_nonmem(.bbi_object, .check_exists) : ...
delete_models(mod2, .tags = NULL)
from bbr.
may want to include the model_summary() bug for when no directory exists
@seth127 @barrettk Should be resolved by gh-573 (see first two commits).
from bbr.
Related Issues (20)
- Bootstrap: function adjustments needed HOT 4
- Address deprecated warning in function `check_grd`
- Bootstrap runs should inherit attached bbi_args HOT 1
- inherit_param_estimates: revisit rounding and use matrix-handling PR HOT 1
- check_nonmem_finished and get_model_status refactor: improve wait times & change functionality HOT 9
- WK files created by bbr - delete by default? HOT 7
- Consider fail-safe for checking on terminated models HOT 4
- bbi package installation failed HOT 8
- Option to start bootstrap runs at final estimates from parent run HOT 3
- No error or warning when trying to overwrite run when `.wait = FALSE` HOT 15
- Re-name msf file in bootstrap run control stream HOT 1
- Submitting bootstrap run in batches can leave lots of unused compute HOT 2
- Bootstrap batch submission sometimes chokes when called before setup is done HOT 2
- Revisit `check_up_to_date` for `nmboot` models HOT 1
- push back minimum snapshot? HOT 5
- Feature: update $TABLE with a certain format HOT 1
- `bbi_init`: parse `nmfe_options` separately from other `.bbi_args`
- .exclude argument in run_log()
- Can't execute bbr commands via the clusters HOT 8
- Check if model can be passed to `nm_join()`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bbr.