metosin / tilakone Goto Github PK

Hi,

thanks for this neat little library! While exploring it, I was wondering why ::tk/states is a sequence of maps with ::tk/name rather than a map with ::tk/name as keys. The latter would take care of preventing duplicate state definitions (which AFAICT don't serve a purpose and aren't detected by the validation function right now) as well as improve performance for large state machines because currently, each state lookup requires a linear search. I'm happy to provide a patch if you're interested. If so, let me know if you would like to retain backwards compatibility with the current API.

Hello!

I've added this as a dependency but it is compiling with errors on a cljs project.

------ WARNING #1 - :undeclared-var --------------------------------------------
 Resource: tilakone/util.cljc:104:20
 Use of undeclared Var tilakone.util/format
--------------------------------------------------------------------------------

------ WARNING #2 - :undeclared-var --------------------------------------------
 Resource: tilakone/util.cljc:114:20
 Use of undeclared Var tilakone.util/format
--------------------------------------------------------------------------------

Apparently 616410a solves this. Can you push it to clojars, please?
I have no clue how to add remote repos as dependencies.

Thanks for the library!

Cool little library.

The examples in the readme and examples directory don't work with version 0.0.4 which is the dependency given in the readme. The readme and simple.clj examples throw null pointer exceptions.

It took me a bit to discover that there's a 0.0.5-SNAPSHOT on clojars that is needed for the examples to work.