metbril / pyluchtmeetnet

A python package to use the Luchtmeetnet 2020 OpenAPI.

Hi there 👋

pyluchtmeetnet's Issues

Supported Python versions

Add some logic or documentation to be able to test (with CI/CD) which versions are supported and working

https://devguide.python.org/versions/

The library should at least support any supported Python version (with security fixes) and possible the next prerelease (to see in advance if any modifications are required).

Add specific versions to workflow

actions/checkout --> 2.4.0
actions/setup-python --> 2.3.1

Useful for dependabot

Return latest measurements only

In #16 I discovered that the get_latest_station_measurements method does return all measurements instead of just the latest. The method should return only the most recent measurement for each component.

Add dependabot

Does not work on station NL54004.

Describe the bug
When using pyluchtmeetnet to obtain the data from my location, connecting to station NL54004, I receive an error.

When debugging your code, I can see that this station provides data on the following components: ['FN', 'NO', 'NO2', 'PM10']
But when collecting the related data, only data for FN and PM10 are returned.

Your present code:

        data = []
        for component in components:
            json_component = [
                meas for meas in measurements if meas["formula"] == component
            ]
            element = {
                component: json_component[0]["value"],
                "timestamp": json_component[0]["timestamp_measured"],
            }
            data.append(element)

fails on this returned data.

When I change to code to this:

        data = []  
        for component in components:
            for meas in measurements:
                if meas["formula"] == component:
                    json_component = [meas]
                    element = {
                        component: json_component[0]["value"],
                        "timestamp": json_component[0]["timestamp_measured"],
                    }
                    data.append(element)

it works on the returned data.