metaphorshear / gene-nation Goto Github PK

The Thread classes seem in particular not to check whether the semaphores and 
functions are set to None or not before using them.

Currently, after each iteration of the pool has completed, all remaining 
genomes have their money reset to $1000. A strategy that performed poorly one 
year has a new chance to do well, but there is no way of knowing which strategy 
was truly the best over all iterations.

Recommend making this optional, and also keeping track of money earned by each 
genome for each iteration, so the winner can be chosen with greater accuracy.

"vals = {key: conn.execute(select([a[1] for a in s.this.c.items() if a[0] != 
'key']).where(s.this.c.key == key)).fetchall() for key in self.keys }" would be 
better constructed as a single query, for speed and efficiency's sake.

Currently, per the StackExchange thread, too many exceptions are ignored within 
threads. It would be better to find which exact exceptions I don't care about, 
and handle the important ones properly.

"if isinstance(func, collections.abc.Sequence):" can replace "if type(func) is 
list", thus supporting all similar data structures.

http://codereview.stackexchange.com/questions/32890/is-this-code-thread-safe

Per suggestions there, I think the non-SQL version of this code might not need 
threading. I will have to give multiprocess a second look.

http://codereview.stackexchange.com/questions/32890/is-this-code-thread-safe

From this same thread, semaphores should be replaced with Thread Pool or 
something similar.

What steps will reproduce the problem?
1. Run the program and leave it alone.
2. Look at the output after at least half an hour, usually during the choose or 
bids routine for a new offspring.
3. Attempts to stop with keyboard interrupt may or may not work.

What is the expected output? What do you see instead?
There should be a continual flow of new data until all iterations of the gene 
pool have been completed. Instead, it hangs. This is probably a multi-threading 
related issue.

What steps will reproduce the problem?
1. Run the bids function under genome, preferably under Windows
2. Observe that on occasion, the output from several threads is interleaved, 
resulting in unintelligible messages
3. E.g., "Putting in an order for 4 shares of Putting in an order for 5 shares 
BVLD of GOOG @ 4.15 for a total of @ 62 for a total of 1000" (note, don't try 
to do the math on these numbers; they are fake and do not add up)

I recommend following some of the advice at 
http://stackoverflow.com/questions/3029816/how-do-i-get-a-thread-safe-print-in-p
ython-2-6