mercadona / postoffice_django Goto Github PK

We have two options while creating a publisher:

• We want to receive messages from now on (from_now=true)
• We want to receive all messages from the topic history (from_now=false)

To be able to choose, we need to send this parameter

Configure CI to upload new version to PyPi so doing it manually is not needed

https://circleci.com/blog/continuously-deploying-python-packages-to-pypi-with-circleci/

We have an API where Postoffice can list, get and delete undelivered messages. We also send origin_host as a topic's attribute while creating it, but it's not a full URL, it's just the sender's host, for example, http://my-service.com.
We would need to send the full URL for the message's API, like
http://my-service.com/api/messages.
We need to add postoffice_django URLConf into our project URL config so we don't know exactly how that path will be as it could change between projects.

Instead of create topics and publishers in a single command, we has decided split this in two commands, one to create topics and another to create publishers

Send bulk messages in chunks using a env. variable

We need to be able to make API requests to delete messages, so @csrf_exempt should be used on DeleteMessageView

Now we have 3 different config keys:

• POSTOFFICE_URL
• POSTOFFICE_CONSUMERS
• POSTOFFICE_TIMEOUT

Move all of them inside a single POSTOFFICE key

POSTOFFICE = {
    URL: 'http://example.com'
    CONSUMERS: [
        {
            'topic': 'some_topic', 
            'endpoint': 'http://....', 
            'type': 'http', 
            'from_now': True
        }, {
        }
    ]
    TIMEOUT: 0.5
}

Add a makefile that makes developers life easier when contributing in this repo.
Makefile commands would allow to:

• Start local environment
• Run tests

Also include a How to contribute section which includes how to add a migration.

• Run tests CircleCI
• Test in several environments with tox
• Coverage report

To can send message to pubsub, all messages params values must be str

We have an admin page where we can see failed messages, but no message's information is given in the list. I think we could improve a lot just showing:

• topic
• error
• created_at

When postoffice sent a validation error, use the 400 code, instead of the 422 that returned previously.

We must update this to retrieve all the errors sent by postoffice

From https://sentry.prod.monline/mdona-production/dispatch-api/issues/15595/?query=is%3Aunresolved

After reading the code, data is serialized before doing the post, but serialized message is not passed when handling the error.

We're setting a timeout in the publish method, but if a timeout occurs it will raise an exception that we're not handling. Moreover, those messages won't be saved to be recovered from postoffice as the execution will exit before the _save_publishing_error()

In order PosOffice to know from where a topic is created, we need to create it with an origin host url.