Comments (4)
Does your module support rate limiting? If so, how to activate it? What about caching? Are there any 3rd party modules that you can recommend integrating for that purpose?
I'm afraid you will have to be more specific with your question.
The HTTPClient will respect 429s sent by Spotify but it's current implementation assumes that rate limits are applied on a per request scenario, based what I've read from Spotify's documentation. This has been the approach since the first release of spotify.py and no issues have been reported.
The library as a whole prefers to avoid caching. This is the case because it's simply the simplest and best solution.
Best case scenario is that the library does include a caching mechanism, but in order to invalidate that cache once a resource has been modified Spotify must be able to communicate that a change has occured and this will require a real time communication channel established between the client and Spotify but Spotify does not provide this.
A less than optimal solution is that the library implements a polling mechanism to automatically update the internal state of Spotify objects. This will require, at least, an overhead of one api call per spotify object alive. This overhead cost will add up very quickly and cause rate limits to be triggered much earlier. Not to mention the added complexity to the library by adding a client cache api with polling mechanisms.
Worst case scenario is that we throw our hands up in the air and let the user handle any and all caching with the lib low level api. This is extra work for the user and most times not that critical a feature to have. Not to mention it's more error prone than a groomed and maintained solution present in the library already.
The current solution is better than any one that requires any sort of direct rest api polling feature and still just shy of the best case solution only limited by Spotify. We simply dont perform any caching across the client session, this reduces complexity and keeps the library to a close 1:1 with the rest api itself.
from spotify.py.
Thanks for elaborating. This makes sense.
Will spotify.py wait and retry in case of 429s?
from spotify.py.
Yes see: https://github.com/mental32/spotify.py/blob/master/spotify/http.py#L185
from spotify.py.
Great, thanks. Resolved.
from spotify.py.
Related Issues (20)
- Impossible to play list of tracks HOT 2
- Player.progress_ms is only set once and not updated HOT 4
- 'Payload' referenced before assignment HOT 3
- Spotify Register Problem HOT 4
- Issue with session closing HOT 3
- Example with an async http server HOT 4
- OAuth needs "scopes" oauth2_url use "scope"
- edit_playlist issues when calling change_playlist_details
- Can't use parameters with user.top_artists() HOT 2
- Better http throttling post 429s HOT 2
- Right, so I've investigated the issue and have a possible fix ready. HOT 2
- Playlist attribute `tracks` is always None HOT 8
- Suggestion: allow User.recently_played() to take same optional parameters as Http.recently_played() HOT 1
- Suggestion: add support for "Add an Item to the User's Playback Queue" endpoint
- When creating a Playlist using the result of HttpClient.get_playlist() an error occurs
- Todo: Support new "Podcasts API"
- When using album.get_all_tracks(), an error is produced. `'Nonetype' has no attribute 'images'` HOT 2
- TypeError: __await__() returned a coroutine HOT 2
- Receiving an error when trying to initialize player HOT 2
- Not possible to install spotify.py and pyspotify at the same time HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spotify.py.